components/password_manager/content/browser/content_password_manager_driver_unittest.cc - Issue 1852093002: components/password_manager: scoped_ptr -> unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/content_password_manager_driver_unittest.cc

Issue 1852093002: components/password_manager: scoped_ptr -> unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and revert an accidental .proto change Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/browser/content_password_manager_driver_factory.cc ('k') | components/password_manager/content/browser/credential_manager_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/content_password_manager_driver_unittest.cc

diff --git a/components/password_manager/content/browser/content_password_manager_driver_unittest.cc b/components/password_manager/content/browser/content_password_manager_driver_unittest.cc

index 551fcb5c4cf4c343c07035d0586944a905e7e3a1..267aa3797ac7348c166682252865e2c2bc97265f 100644

--- a/components/password_manager/content/browser/content_password_manager_driver_unittest.cc

+++ b/components/password_manager/content/browser/content_password_manager_driver_unittest.cc

@@ -74,7 +74,7 @@ class ContentPasswordManagerDriverTest

TEST_P(ContentPasswordManagerDriverTest,

AnswerToNotificationsAboutLoggingState) {

const bool should_allow_logging = GetParam();

- scoped_ptr<ContentPasswordManagerDriver> driver(

+ std::unique_ptr<ContentPasswordManagerDriver> driver(

new ContentPasswordManagerDriver(main_rfh(), &password_manager_client_,

&autofill_client_));

process()->sink().ClearMessages();

@@ -95,7 +95,7 @@ TEST_P(ContentPasswordManagerDriverTest,

TEST_P(ContentPasswordManagerDriverTest, AnswerToIPCPingsAboutLoggingState) {

const bool should_allow_logging = GetParam();

- scoped_ptr<ContentPasswordManagerDriver> driver(

+ std::unique_ptr<ContentPasswordManagerDriver> driver(

new ContentPasswordManagerDriver(main_rfh(), &password_manager_client_,

&autofill_client_));