Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3661)

Unified Diff: ash/shell/shelf_delegate_impl.cc

Issue 1851883002: Cleanup shelf initialization and observation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Check for shelf before setting prefs in ChromeLauncherController. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shell/shelf_delegate_impl.cc
diff --git a/ash/shell/shelf_delegate_impl.cc b/ash/shell/shelf_delegate_impl.cc
index b77da8bc71c45327bc719de16e0291bef77102b6..48e7e3be522b3071827aae1fe0c862e0c4375b68 100644
--- a/ash/shell/shelf_delegate_impl.cc
+++ b/ash/shell/shelf_delegate_impl.cc
@@ -11,14 +11,15 @@ namespace shell {
ShelfDelegateImpl::ShelfDelegateImpl() {}
-ShelfDelegateImpl::~ShelfDelegateImpl() {
-}
+ShelfDelegateImpl::~ShelfDelegateImpl() {}
-void ShelfDelegateImpl::OnShelfCreated(Shelf* shelf) {
-}
+void ShelfDelegateImpl::OnShelfCreated(Shelf* shelf) {}
-void ShelfDelegateImpl::OnShelfDestroyed(Shelf* shelf) {
-}
+void ShelfDelegateImpl::OnShelfDestroyed(Shelf* shelf) {}
+
+void ShelfDelegateImpl::OnShelfAlignmentChanged(Shelf* shelf) {}
+
+void ShelfDelegateImpl::OnShelfAutoHideBehaviorChanged(Shelf* shelf) {}
ShelfID ShelfDelegateImpl::GetShelfIDForAppID(const std::string& app_id) {
return 0;
@@ -32,15 +33,13 @@ const std::string& ShelfDelegateImpl::GetAppIDForShelfID(ShelfID id) {
return base::EmptyString();
}
-void ShelfDelegateImpl::PinAppWithID(const std::string& app_id) {
-}
+void ShelfDelegateImpl::PinAppWithID(const std::string& app_id) {}
bool ShelfDelegateImpl::IsAppPinned(const std::string& app_id) {
return false;
}
-void ShelfDelegateImpl::UnpinAppWithID(const std::string& app_id) {
-}
+void ShelfDelegateImpl::UnpinAppWithID(const std::string& app_id) {}
} // namespace shell
} // namespace ash
« ash/shelf/shelf.cc ('K') | « ash/shell/shelf_delegate_impl.h ('k') | ash/shell_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698