ash/shelf/shelf_view_unittest.cc - Issue 1851883002: Cleanup shelf initialization and observation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shelf/shelf_view_unittest.cc

Issue 1851883002: Cleanup shelf initialization and observation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check for shelf before setting prefs in ChromeLauncherController. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/shelf/shelf_view_unittest.cc

diff --git a/ash/shelf/shelf_view_unittest.cc b/ash/shelf/shelf_view_unittest.cc

index 76655c3baab035322051ff7a0ef2483a3c3f57ed..2888436d7f362eca090cd5e1788ad069d6dc6236 100644

--- a/ash/shelf/shelf_view_unittest.cc

+++ b/ash/shelf/shelf_view_unittest.cc

@@ -250,6 +250,10 @@ class TestShelfDelegateForShelfView : public ShelfDelegate {

void OnShelfDestroyed(Shelf* shelf) override {}

+ void OnShelfAlignmentChanged(Shelf* shelf) override {}

+ void OnShelfAutoHideBehaviorChanged(Shelf* shelf) override {}

ShelfID GetShelfIDForAppID(const std::string& app_id) override {

ShelfID id = 0;

EXPECT_TRUE(base::StringToInt(app_id, &id));