Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2759)

Unified Diff: ash/shelf/shelf_alignment_menu.cc

Issue 1851883002: Cleanup shelf initialization and observation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Check for shelf before setting prefs in ChromeLauncherController. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shelf/shelf_alignment_menu.cc
diff --git a/ash/shelf/shelf_alignment_menu.cc b/ash/shelf/shelf_alignment_menu.cc
index 8a9d89326942c6f91652312384b8588966db7c55..f274ced1528ba9b7959c7e0093a6f401dede5a66 100644
--- a/ash/shelf/shelf_alignment_menu.cc
+++ b/ash/shelf/shelf_alignment_menu.cc
@@ -6,9 +6,7 @@
#include "ash/metrics/user_metrics_recorder.h"
#include "ash/shelf/shelf.h"
-#include "ash/shelf/shelf_layout_manager.h"
#include "ash/shelf/shelf_types.h"
-#include "ash/shelf/shelf_widget.h"
#include "ash/shell.h"
#include "grit/ash_strings.h"
#include "ui/aura/window.h"
@@ -51,19 +49,18 @@ bool ShelfAlignmentMenu::GetAcceleratorForCommandId(
void ShelfAlignmentMenu::ExecuteCommand(int command_id, int event_flags) {
Shell* shell = Shell::GetInstance();
- ShelfLayoutManager* manager = shelf_->shelf_widget()->shelf_layout_manager();
switch (static_cast<MenuItem>(command_id)) {
case MENU_ALIGN_LEFT:
shell->metrics()->RecordUserMetricsAction(UMA_SHELF_ALIGNMENT_SET_LEFT);
- manager->SetAlignment(SHELF_ALIGNMENT_LEFT);
+ shelf_->SetAlignment(SHELF_ALIGNMENT_LEFT);
break;
case MENU_ALIGN_BOTTOM:
shell->metrics()->RecordUserMetricsAction(UMA_SHELF_ALIGNMENT_SET_BOTTOM);
- manager->SetAlignment(SHELF_ALIGNMENT_BOTTOM);
+ shelf_->SetAlignment(SHELF_ALIGNMENT_BOTTOM);
break;
case MENU_ALIGN_RIGHT:
shell->metrics()->RecordUserMetricsAction(UMA_SHELF_ALIGNMENT_SET_RIGHT);
- manager->SetAlignment(SHELF_ALIGNMENT_RIGHT);
+ shelf_->SetAlignment(SHELF_ALIGNMENT_RIGHT);
break;
}
}
« ash/shelf/shelf.cc ('K') | « ash/shelf/shelf.cc ('k') | ash/shelf/shelf_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698