Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1851843002: Revert of Propagate is_official_build to version script. (Closed)

Created:
4 years, 8 months ago by Sami
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Propagate is_official_build to version script. (patchset #1 id:1 of https://codereview.chromium.org/1838173005/ ) Reason for revert: Made all the Android perf bots red: https://bugs.chromium.org/p/chromium/issues/detail?id=599830 Original issue's description: > Propagate is_official_build to version script. > > OFFICIAL_BUILD is a special variable in the version script which > takes its value from the environment variable. This means that local > builds with is_official_build will not actually result in > ChromeVersionConstants.isOfficialBuild() returning true. > > This CL propagates the is_official_build truthiness to the script so > official builds no longer depend solely on the environment variable. > > BUG=599268 > > Committed: https://crrev.com/eab85df0275b825e428954c4030e358ce968ecd9 > Cr-Commit-Position: refs/heads/master@{#384340} TBR=agrieve@chromium.org,thestig@chromium.org,wnwen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=599268 Committed: https://crrev.com/756e9b934bf1d706dd59ab39bed2af842b67063b Cr-Commit-Position: refs/heads/master@{#384610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M build/util/version.py View 4 chunks +3 lines, -7 lines 0 comments Download
M chrome/version.gni View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Sami
Created Revert of Propagate is_official_build to version script.
4 years, 8 months ago (2016-04-01 16:55:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851843002/1
4 years, 8 months ago (2016-04-01 16:55:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 16:56:20 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/756e9b934bf1d706dd59ab39bed2af842b67063b Cr-Commit-Position: refs/heads/master@{#384610}
4 years, 8 months ago (2016-04-01 16:57:43 UTC) #5
Peter Wen
4 years, 8 months ago (2016-04-04 17:26:46 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1856843002/ by wnwen@chromium.org.

The reason for reverting is: The actual crash was in OmahaClient, which is fixed
in: http://crrev.com/1856823002.

Powered by Google App Engine
This is Rietveld 408576698