Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 1851823002: Revert of PPC: [compiler] Add relocatable pointer constants for wasm memory references. (Closed)

Created:
4 years, 8 months ago by MTBrandyberry
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of PPC: [compiler] Add relocatable pointer constants for wasm memory references. (patchset #1 id:1 of https://codereview.chromium.org/1851543004/ ) Reason for revert: Original commit reverted. Original issue's description: > PPC: [compiler] Add relocatable pointer constants for wasm memory references. > > Port eb5fe0df64ec0add423b2a1f6fb62d5a33dce2a5 > > Original commit message: > Add relocatable pointers for wasm memory references that need to > be updated when wasm GrowMemory is used. Code generator changes to > accept relocatable constants as immediates. > > R=gdeepti@google.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com > BUG= > > Committed: https://crrev.com/ba053c4620c3b91ddc540f733f8b4dd9a792bb13 > Cr-Commit-Position: refs/heads/master@{#35203} TBR=gdeepti@google.com,joransiu@ca.ibm.com,jyan@ca.ibm.com,michael_dawson@ca.ibm.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/bdfe29afad9c4332230c271639bcf38683e3cc21 Cr-Commit-Position: refs/heads/master@{#35210}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -18 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +2 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
MTBrandyberry
Created Revert of PPC: [compiler] Add relocatable pointer constants for wasm memory references.
4 years, 8 months ago (2016-04-01 15:29:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851823002/1
4 years, 8 months ago (2016-04-01 15:29:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 15:29:51 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 15:31:18 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bdfe29afad9c4332230c271639bcf38683e3cc21
Cr-Commit-Position: refs/heads/master@{#35210}

Powered by Google App Engine
This is Rietveld 408576698