Make blink_headers depend on mojo_bindings

Make blink_headers generate mojo bindings

We need to generate mojo bindings for targets that depend on
blink_headers e.g. Web Crypto Fuzzers.

BUG=600384
Committed: https://crrev.com/06bad69ca9182b8db51dfc121928a1dd11bd4799
Cr-Commit-Position: refs/heads/master@{#387475}

[ortuno, 2016-04-01 21:09:34]

Description was changed from

==========
Make blink_headers depend on mojo_bindings

We need to generate mojo bindings for targets that depend on
blink_headers.

BUG=599959
==========

to

==========
Make blink_headers depend on mojo_bindings

We need to generate mojo bindings for targets that depend on
blink_headers e.g. Web Crypto Fuzzers.

BUG=599959
==========

[Ken Rockot(use gerrit already), 2016-04-01 21:32:07]

rockot@chromium.org changed reviewers:
+ rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-04-01 21:32:08]

lgtm but you should get dpranke or thakis to look per OWNERS.

this *may* cause duplicate definition errors, depending on how blink_headers is
used. we might need an intermediate target so blink_headers can depend on
mojom.h generation without depending on the generated source_set/static_library.

[Ken Rockot(use gerrit already), 2016-04-01 21:33:19]

On 2016/04/01 at 21:32:08, Ken Rockot (OOO Mar30 - Apr05) wrote:
> lgtm but you should get dpranke or thakis to look per OWNERS.
> 
> this *may* cause duplicate definition errors, depending on how blink_headers
is used. we might need an intermediate target so blink_headers can depend on
mojom.h generation without depending on the generated source_set/static_library.

also, extra : in gyp :)

[ortuno, 2016-04-02 00:05:07]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-02 00:05:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851813003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851813003/80001

[commit-bot: I haz the power, 2016-04-02 00:25:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-02 00:25:06]

Dry run: Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Ken Rockot(use gerrit already), 2016-04-02 20:53:40]

Gyp errors are fun. Perhaps your problem is "depenencies" :)

[ortuno, 2016-04-03 00:59:46]

On 2016/04/02 at 20:53:40, rockot wrote:
> Gyp errors are fun. Perhaps your problem is "depenencies" :)

Gaahh. Fix the typo but now we are back at "undefined reference" errors :(

[ortuno, 2016-04-04 16:56:54]

Hmm I think this gets closer to the solution:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/chrome_web_...
but I think it will break if someone included a blink variant.

[Ken Rockot(use gerrit already), 2016-04-04 19:03:57]

On 2016/04/04 at 16:56:54, ortuno wrote:
> Hmm I think this gets closer to the solution:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/chrome_web_...
but I think it will break if someone included a blink variant.

Not sure we should do this, as it means duplicating a mojom sources list. Also,
it should be functionally equivalent to having the 'none' target depend only on
blink.gyp:mojo_bindings.

This might sound horrible, but could you please try using a *second*
intermediate target? So something like 

  {
    'target_name': 'generate_mojo_bindings_indirect',
    'type': 'none',
    'dependencies': [
      'blink.gyp:mojo_bindings',
    ],
    'hard_dependency': 1,
  },
  {
    'target_name': 'generate_mojo_bindings',
    'type': 'none',
    'dependencies': [
      'generate_mojo_bindings_indirect',
    ],
    'hard_dependency': 1,
  },

And have 'blink_headers' depend on 'generate_mojo_bindings'.

I think the linker errors are due to the way 'export_dependent_settings' works.
Anything which depends on blink_headers is still getting a link-time dependency
on mojo libraries which they shouldn't have.

Adding another target for indirection should wipe out any exported settings by
the time the dependency reaches blink_headers. Should. Maybe. I hope.

[ortuno, 2016-04-04 20:46:16]

On 2016/04/04 at 19:03:57, rockot wrote:
> On 2016/04/04 at 16:56:54, ortuno wrote:
> > Hmm I think this gets closer to the solution:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/chrome_web_...
but I think it will break if someone included a blink variant.
> 
> Not sure we should do this, as it means duplicating a mojom sources list.

We can make it a gypi. The sources are already in a variable and used in two
places.

> Also, it should be functionally equivalent to having the 'none' target depend
only on blink.gyp:mojo_bindings.
> 

Yeah that's what I thought. But for some reason it works if I do it that way;
see Patch 9.

> This might sound horrible, but could you please try using a *second*
intermediate target? So something like 
> 
>   {
>     'target_name': 'generate_mojo_bindings_indirect',
>     'type': 'none',
>     'dependencies': [
>       'blink.gyp:mojo_bindings',
>     ],
>     'hard_dependency': 1,
>   },
>   {
>     'target_name': 'generate_mojo_bindings',
>     'type': 'none',
>     'dependencies': [
>       'generate_mojo_bindings_indirect',
>     ],
>     'hard_dependency': 1,
>   },
> 
> And have 'blink_headers' depend on 'generate_mojo_bindings'.
> 
> I think the linker errors are due to the way 'export_dependent_settings'
works. Anything which depends on blink_headers is still getting a link-time
dependency on mojo libraries which they shouldn't have.
> 
> Adding another target for indirection should wipe out any exported settings by
the time the dependency reaches blink_headers. Should. Maybe. I hope.

Still the same problem :(

[Ken Rockot(use gerrit already), 2016-04-06 14:25:26]

OK PS9 looks good if we use a gypi

[ortuno, 2016-04-14 17:29:57]

Description was changed from

==========
Make blink_headers depend on mojo_bindings

We need to generate mojo bindings for targets that depend on
blink_headers e.g. Web Crypto Fuzzers.

BUG=599959
==========

to

==========
Make blink_headers depend on mojo_bindings

We need to generate mojo bindings for targets that depend on
blink_headers e.g. Web Crypto Fuzzers.

BUG=600384
==========

[ortuno, 2016-04-14 22:34:00]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-14 22:34:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851813003/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851813003/220001

[ortuno, 2016-04-14 22:53:19]

rockot: All bots seem happy. PTAL

[Ken Rockot(use gerrit already), 2016-04-14 22:54:49]

lgtm

[ortuno, 2016-04-14 22:59:15]

ortuno@chromium.org changed reviewers:
+ esprehn@chromium.org

[ortuno, 2016-04-14 22:59:16]

esprehn: PTAL

[ortuno, 2016-04-14 22:59:30]

Description was changed from

==========
Make blink_headers depend on mojo_bindings

We need to generate mojo bindings for targets that depend on
blink_headers e.g. Web Crypto Fuzzers.

BUG=600384
==========

to

==========
Make blink_headers generate mojo bindings

We need to generate mojo bindings for targets that depend on
blink_headers e.g. Web Crypto Fuzzers.

BUG=600384
==========

[esprehn, 2016-04-14 23:08:13]

lgtm

[commit-bot: I haz the power, 2016-04-14 23:38:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 23:38:06]

Dry run: This issue passed the CQ dry run.

[ortuno, 2016-04-14 23:38:27]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2016-04-14 23:39:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851813003/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851813003/220001

[commit-bot: I haz the power, 2016-04-14 23:44:53]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2016-04-14 23:47:27]

Description was changed from

==========
Make blink_headers generate mojo bindings

We need to generate mojo bindings for targets that depend on
blink_headers e.g. Web Crypto Fuzzers.

BUG=600384
==========

to

==========
Make blink_headers generate mojo bindings

We need to generate mojo bindings for targets that depend on
blink_headers e.g. Web Crypto Fuzzers.

BUG=600384

Committed: https://crrev.com/06bad69ca9182b8db51dfc121928a1dd11bd4799
Cr-Commit-Position: refs/heads/master@{#387475}
==========

[commit-bot: I haz the power, 2016-04-14 23:47:29]

Patchset 12 (id:??) landed as
https://crrev.com/06bad69ca9182b8db51dfc121928a1dd11bd4799
Cr-Commit-Position: refs/heads/master@{#387475}