Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: chrome/browser/resources/popular_sites_internals.html

Issue 1851803002: [NTP Popular Sites] Store country/version in prefs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/popular_sites_internals.html
diff --git a/chrome/browser/resources/popular_sites_internals.html b/chrome/browser/resources/popular_sites_internals.html
index 65ee20a47a82b7e5177da03440a16a050f5981c4..0757fc86f4843fd40fe24379048d7b75ee078106 100644
--- a/chrome/browser/resources/popular_sites_internals.html
+++ b/chrome/browser/resources/popular_sites_internals.html
@@ -48,6 +48,20 @@ found in the LICENSE file.
</table>
</div>
+ <div class="section" jsskip="true">
+ <h2>Info</h2>
+ <table class="section-details">
+ <tr>
+ <td class="detail">Country</td>
+ <td class="value" id="country"></td>
Bernhard Bauer 2016/04/06 15:41:54 Is there a reason we can't just use jstemplate to
Marc Treib 2016/04/06 16:37:10 Err.. ignorance? :) Done.
+ </tr>
+ <tr>
+ <td class="detail">Version</td>
+ <td class="value" id="version"></td>
+ </tr>
+ </table>
+ </div>
+
<div id="sites" class="section">
<h2>Sites</h2>
<table class="section-details">
@@ -55,7 +69,7 @@ found in the LICENSE file.
<td class="detail" jscontent="title"></td>
<td class="value" jscontent="url"></td>
</tr>
- <tr jsskip = true>
+ <tr jsskip="true">
<td class="detail">
<input id="view-json" type="submit" value="View JSON">
</td>

Powered by Google App Engine
This is Rietveld 408576698