extensions/browser/guest_view/web_view/web_view_find_helper.cc - Issue 1851793002: Implement a shell of FindRequestManager, and hook it up to WebContentsImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_find_helper.cc

Issue 1851793002: Implement a shell of FindRequestManager, and hook it up to WebContentsImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl.cc ('K') | « content/public/browser/web_contents.h ('k') | extensions/browser/guest_view/web_view/web_view_guest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/web_view_find_helper.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_find_helper.cc b/extensions/browser/guest_view/web_view/web_view_find_helper.cc

index f9a315f68f3286ce67ddf9c70344a0f9b5eced80..268437f65694dd5a496966f2bd4ade376adc7260 100644

--- a/extensions/browser/guest_view/web_view/web_view_find_helper.cc

+++ b/extensions/browser/guest_view/web_view/web_view_find_helper.cc

@@ -157,13 +157,13 @@ void WebViewFindHelper::FindReply(int request_id,

DCHECK(current_find_session_);

WebViewFindHelper::FindInfo* find_info = find_iterator->second.get();

// Handle canceled find requests.

if (!find_info->options()->findNext &&

find_info_map_.begin()->first < request_id) {

DCHECK_NE(current_find_session_->request_id(),

find_info_map_.begin()->first);

- DispatchFindUpdateEvent(true /* canceled */, true /* final_update */);

+ if (find_update_event_.get())

dcheng 2016/04/04 18:59:52 Nit: no .get()

paulmeyer 2016/04/04 20:07:47 Done.

+ DispatchFindUpdateEvent(true /* canceled */, true /* final_update */);

EndFindSession(find_info_map_.begin()->first, true /* canceled */);

}