Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1624)

Unified Diff: pkg/compiler/lib/src/options.dart

Issue 1851753002: Enable conditional directives by default. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Fix analyzer test. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/dart2js.dart ('k') | pkg/compiler/lib/src/parser/parser.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/options.dart
diff --git a/pkg/compiler/lib/src/options.dart b/pkg/compiler/lib/src/options.dart
index cede0d120935b5e36241fac90f26725499abc80b..84c8a807afe18e5c432f2924668e801b2f4ea009 100644
--- a/pkg/compiler/lib/src/options.dart
+++ b/pkg/compiler/lib/src/options.dart
@@ -14,9 +14,6 @@ import '../compiler.dart' show PackagesDiscoveryProvider;
abstract class ParserOptions {
const ParserOptions();
- /// Support conditional directives, e.g., configurable imports.
- bool get enableConditionalDirectives;
-
/// Support parsing of generic method declarations, and invocations of
/// methods where type arguments are passed.
bool get enableGenericMethodSyntax;
@@ -148,9 +145,6 @@ class CompilerOptions implements DiagnosticOptions, ParserOptions {
/// reason for why an assertion fails. (experimental)
final bool enableAssertMessage;
- /// Whether to enable the experimental conditional directives feature.
- final bool enableConditionalDirectives;
-
/// Support parsing of generic method declarations, and invocations of
/// methods where type arguments are passed.
final bool enableGenericMethodSyntax;
@@ -285,8 +279,6 @@ class CompilerOptions implements DiagnosticOptions, ParserOptions {
emitJavaScript: !(_hasOption(options, '--output-type=dart') ||
_hasOption(options, '--output-type=dart-multi')),
enableAssertMessage: _hasOption(options, Flags.enableAssertMessage),
- enableConditionalDirectives:
- _hasOption(options, Flags.conditionalDirectives),
enableGenericMethodSyntax:
_hasOption(options, Flags.genericMethodSyntax),
enableExperimentalMirrors:
@@ -354,7 +346,6 @@ class CompilerOptions implements DiagnosticOptions, ParserOptions {
bool dumpInfo: false,
bool emitJavaScript: true,
bool enableAssertMessage: false,
- bool enableConditionalDirectives: false,
bool enableGenericMethodSyntax: false,
bool enableExperimentalMirrors: false,
bool enableMinification: false,
@@ -424,7 +415,6 @@ class CompilerOptions implements DiagnosticOptions, ParserOptions {
dumpInfo: dumpInfo,
emitJavaScript: emitJavaScript,
enableAssertMessage: enableAssertMessage,
- enableConditionalDirectives: enableConditionalDirectives,
enableGenericMethodSyntax: enableGenericMethodSyntax,
enableExperimentalMirrors: enableExperimentalMirrors,
enableMinification: enableMinification,
@@ -475,7 +465,6 @@ class CompilerOptions implements DiagnosticOptions, ParserOptions {
this.dumpInfo: false,
this.emitJavaScript: true,
this.enableAssertMessage: false,
- this.enableConditionalDirectives: false,
this.enableGenericMethodSyntax: false,
this.enableExperimentalMirrors: false,
this.enableMinification: false,
« no previous file with comments | « pkg/compiler/lib/src/dart2js.dart ('k') | pkg/compiler/lib/src/parser/parser.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698