Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: pkg/analysis_server/test/context_manager_test.dart

Issue 1851753002: Enable conditional directives by default. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Fix analyzer test. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/generated/engine.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/context_manager_test.dart
diff --git a/pkg/analysis_server/test/context_manager_test.dart b/pkg/analysis_server/test/context_manager_test.dart
index 4a78b6be017e33d3a623da4e2f3b8b048ff94b40..123cabe93f9b0e5e4611b9e556700471c40e97d6 100644
--- a/pkg/analysis_server/test/context_manager_test.dart
+++ b/pkg/analysis_server/test/context_manager_test.dart
@@ -400,7 +400,6 @@ analyzer:
language:
enableGenericMethods: true
enableAsync: false
- enableConditionalDirectives: true
errors:
unused_local_variable: false
linter:
@@ -426,7 +425,6 @@ linter:
expect(context.analysisOptions.enableAsync, isFalse);
// * from `.analysis_options`:
expect(context.analysisOptions.enableGenericMethods, isTrue);
- expect(context.analysisOptions.enableConditionalDirectives, isTrue);
// * verify tests are excluded
expect(
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/generated/engine.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698