Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: pkg/compiler/lib/src/patch_parser.dart

Issue 1851753002: Enable conditional directives by default. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/patch_parser.dart
diff --git a/pkg/compiler/lib/src/patch_parser.dart b/pkg/compiler/lib/src/patch_parser.dart
index fb2e437048ae709b5bf2282804e6453a7365ad99..1037df5a54d377ff94e9ec253ed5409e81d76898 100644
--- a/pkg/compiler/lib/src/patch_parser.dart
+++ b/pkg/compiler/lib/src/patch_parser.dart
@@ -159,11 +159,8 @@ import 'tokens/token.dart' show
class PatchParserTask extends CompilerTask {
final String name = "Patching Parser";
- final bool _enableConditionalDirectives;
- PatchParserTask(Compiler compiler, {bool enableConditionalDirectives})
- : this._enableConditionalDirectives = enableConditionalDirectives,
- super(compiler);
+ PatchParserTask(Compiler compiler) : super(compiler);
/**
* Scans a library patch file, applies the method patches and
@@ -198,9 +195,7 @@ class PatchParserTask extends CompilerTask {
compilationUnit,
idGenerator);
try {
- new PartialParser(patchListener,
- enableConditionalDirectives: _enableConditionalDirectives)
- .parseUnit(tokens);
+ new PartialParser(patchListener).parseUnit(tokens);
} on ParserError catch (e) {
// No need to recover from a parser error in platform libraries, user
// will never see this if the libraries are tested correctly.
@@ -217,8 +212,7 @@ class PatchParserTask extends CompilerTask {
measure(() => reporter.withCurrentElement(cls, () {
MemberListener listener = new PatchMemberListener(compiler, cls);
- Parser parser = new PatchClassElementParser(
- listener, enableConditionalDirectives: _enableConditionalDirectives);
+ Parser parser = new PatchClassElementParser(listener);
try {
Token token = parser.parseTopLevelDeclaration(cls.beginToken);
assert(identical(token, cls.endToken.next));
@@ -270,9 +264,7 @@ class PatchMemberListener extends MemberListener {
* declarations.
*/
class PatchClassElementParser extends PartialParser {
- PatchClassElementParser(Listener listener, {bool enableConditionalDirectives})
- : super(listener,
- enableConditionalDirectives: enableConditionalDirectives);
+ PatchClassElementParser(Listener listener) : super(listener);
Token parseClassBody(Token token) => fullParseClassBody(token);
}

Powered by Google App Engine
This is Rietveld 408576698