Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: pkg/analysis_server/test/context_manager_test.dart

Issue 1851753002: Enable conditional directives by default. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/context_manager_test.dart
diff --git a/pkg/analysis_server/test/context_manager_test.dart b/pkg/analysis_server/test/context_manager_test.dart
index cee64f0b68763218d6ee04d3af9b9f204119848b..ec6573a4e5fcb4da9d76ff385c4e32da313fb260 100644
--- a/pkg/analysis_server/test/context_manager_test.dart
+++ b/pkg/analysis_server/test/context_manager_test.dart
@@ -399,7 +399,6 @@ analyzer:
language:
enableGenericMethods: true
enableAsync: false
- enableConditionalDirectives: true
errors:
unused_local_variable: false
linter:
@@ -425,7 +424,6 @@ linter:
expect(context.analysisOptions.enableAsync, isFalse);
// * from `.analysis_options`:
expect(context.analysisOptions.enableGenericMethods, isTrue);
- expect(context.analysisOptions.enableConditionalDirectives, isTrue);
// * verify tests are excluded
expect(
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/context/context.dart » ('j') | pkg/analyzer/lib/src/generated/engine.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698