runtime/vm/flow_graph.h - Issue 1851653002: Fix bug in receiver-phi computation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph.h

Issue 1851653002: Fix bug in receiver-phi computation. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: fixed recursive version Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph.h

diff --git a/runtime/vm/flow_graph.h b/runtime/vm/flow_graph.h

index 992ab519fb5762b51ab99ce67abff1f6e4b035d5..c19dc0c33ee8e68a2fc9374752c53bfb0cc00ed3 100644

--- a/runtime/vm/flow_graph.h

+++ b/runtime/vm/flow_graph.h

@@ -356,7 +356,9 @@ class FlowGraph : public ZoneAllocated {

bool is_environment_use);

bool IsReceiver(Definition* def) const;

- void ComputeIsReceiverRecursive(PhiInstr* phi, BitVector* processed) const;

+ void ComputeIsReceiver(PhiInstr* phi) const;

+ void ComputeIsReceiverRecursive(PhiInstr* phi,

+ GrowableArray<PhiInstr*>* unmark) const;

Thread* thread_;

« no previous file with comments | « no previous file | runtime/vm/flow_graph.cc » ('j') | no next file with comments »