Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 1851623002: Issue 26148. Don't use a current token if it does not match - create a new synthetic. (Closed)

Created:
4 years, 8 months ago by scheglov
Modified:
4 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 26148. Don't use a current token if it does not match - create a new synthetic. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/26148 Committed: https://github.com/dart-lang/sdk/commit/054be34e6cda5aca9bcc7c63aa679e9bc0ab3d89

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 8 months ago (2016-03-31 20:09:11 UTC) #1
Brian Wilkerson
LGTM
4 years, 8 months ago (2016-03-31 20:19:33 UTC) #2
scheglov
4 years, 8 months ago (2016-03-31 20:40:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
054be34e6cda5aca9bcc7c63aa679e9bc0ab3d89 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698