Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 18516011: InstantExtended: Remove overlay control code. (Closed)

Created:
7 years, 5 months ago by Jered
Modified:
7 years, 5 months ago
Reviewers:
CC:
chromium-reviews, creis+watch_chromium.org, mad+watch_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, browser-components-watch_chromium.org, Avi (use Gerrit), dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, ajwong+watch_chromium.org, kmadhusu+watch_chromium.org, yoshiki+watch_chromium.org, James Su
Visibility:
Public.

Description

InstantExtended: Remove overlay control code. This change deletes the browser-side InstantController code pertaining to old Instant, the HTML popup and search results overlay. A lot of UI and renderer code is still lingering and doing nothing, but I'll get that in another CL. TEST=Manually. Verify that InstantExtended NTP and searching works, and that normal Chrome is unaffected. BUG=251262 TBR=samarth@chromium.org,pkasting@chromium.org,brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210062

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Re-re-rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -2842 lines) Patch
M chrome/browser/google/google_url_tracker_navigation_helper_impl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/google/google_url_tracker_navigation_helper_impl.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M chrome/browser/history/history_tab_helper.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/rlz/rlz.cc View 2 chunks +0 lines, -7 lines 0 comments Download
D chrome/browser/search/instant_extended_context_menu_observer.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/search/instant_extended_context_menu_observer.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M chrome/browser/search/search.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/search/search.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/task_manager/tab_contents_resource_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/task_manager/tab_contents_resource_provider.cc View 11 chunks +3 lines, -33 lines 0 comments Download
M chrome/browser/ui/browser_instant_controller.h View 1 chunk +1 line, -17 lines 0 comments Download
M chrome/browser/ui/browser_instant_controller.cc View 4 chunks +2 lines, -42 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/render_view_context_menu_mac.mm View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/omnibox/alternate_nav_url_fetcher.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_controller.h View 4 chunks +0 lines, -21 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_controller.cc View 4 chunks +3 lines, -89 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.h View 1 2 3 chunks +1 line, -37 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 1 2 15 chunks +19 lines, -179 lines 0 comments Download
D chrome/browser/ui/search/instant_commit_type.h View 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/browser/ui/search/instant_controller.h View 1 2 13 chunks +15 lines, -258 lines 0 comments Download
M chrome/browser/ui/search/instant_controller.cc View 30 chunks +25 lines, -1272 lines 0 comments Download
M chrome/browser/ui/search/instant_controller_unittest.cc View 7 chunks +0 lines, -88 lines 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/instant_extended_manual_interactive_uitest.cc View 1 2 5 chunks +3 lines, -47 lines 0 comments Download
M chrome/browser/ui/search/instant_ipc_sender.h View 2 chunks +0 lines, -42 lines 0 comments Download
M chrome/browser/ui/search/instant_ipc_sender.cc View 2 chunks +0 lines, -42 lines 0 comments Download
D chrome/browser/ui/search/instant_overlay.h View 1 chunk +0 lines, -105 lines 0 comments Download
D chrome/browser/ui/search/instant_overlay.cc View 1 chunk +0 lines, -148 lines 0 comments Download
M chrome/browser/ui/search/instant_overlay_controller.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/search/instant_overlay_model.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/search/instant_page.h View 4 chunks +2 lines, -25 lines 0 comments Download
M chrome/browser/ui/search/instant_page.cc View 3 chunks +0 lines, -38 lines 0 comments Download
M chrome/browser/ui/search/instant_page_unittest.cc View 1 2 2 chunks +0 lines, -34 lines 0 comments Download
M chrome/browser/ui/search/instant_test_utils.h View 1 2 3 chunks +0 lines, -25 lines 0 comments Download
M chrome/browser/ui/search/instant_test_utils.cc View 6 chunks +2 lines, -68 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_notification_types.h View 2 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jered
My previous attempt in 18223002 got reverted because it broke the rlz build (which evidently ...
7 years, 5 months ago (2013-07-03 21:24:46 UTC) #1
Jered
7 years, 5 months ago (2013-07-03 23:09:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #3 manually as r210062 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698