Implemented completion pings for component updates.

chrome/browser/component_updater/component_updater_service.h

Index: chrome/browser/component_updater/component_updater_service.h
diff --git a/chrome/browser/component_updater/component_updater_service.h b/chrome/browser/component_updater/component_updater_service.h
index de1748bdd947b259970be3bfe1423fe3bb4c4591..abb71898d37d1f741db7482c27ecb2be65ebf9c8 100644
--- a/chrome/browser/component_updater/component_updater_service.h
+++ b/chrome/browser/component_updater/component_updater_service.h
@@ -20,6 +20,7 @@ class DictionaryValue;
 class FilePath;
 }
 
+class ComponentInstaller;

[cpu_(ooo_6.6-7.5), 2013/07/03 22:34:34]

needed?

[Sorin Jianu, 2013/07/03 23:35:13]

No. Removed.

 class ComponentPatcher;
 
 // Component specific installers must derive from this class and implement
@@ -91,15 +92,6 @@ class ComponentUpdateService {
   // Controls the component updater behavior.
   class Configurator {
    public:
-    enum Events {
-      kManifestCheck,
-      kComponentUpdated,
-      kManifestError,
-      kNetworkError,
-      kUnpackError,
-      kInstallerError
-    };
-
     virtual ~Configurator() {}
     // Delay in seconds from calling Start() to the first update check.
     virtual int InitialDelay() = 0;
@@ -114,6 +106,9 @@ class ComponentUpdateService {
     virtual int OnDemandDelay() = 0;
     // The url that is going to be used update checks over Omaha protocol.
     virtual GURL UpdateUrl() = 0;
+    // The url where the completion pings are sent. Invalid if and only if
+    // pings are disabled.
+    virtual GURL PingUrl() = 0;
     // Parameters added to each url request. It can be null if none are needed.
     virtual const char* ExtraRequestParams() = 0;
     // How big each update request can be. Don't go above 2000.
@@ -122,10 +117,6 @@ class ComponentUpdateService {
     virtual net::URLRequestContextGetter* RequestContext() = 0;
     // True means that all ops are performed in this process.
     virtual bool InProcess() = 0;
-    // The component updater will call this function when an interesting event
-    // happens. It should be used mostly as a place to add application specific
-    // logging or telemetry. |extra| is |event| dependent.
-    virtual void OnEvent(Events event, int extra) = 0;
     // Creates a new ComponentPatcher in a platform-specific way. This is useful
     // for dependency injection.
     virtual ComponentPatcher* CreateComponentPatcher() = 0;