Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: chrome/browser/component_updater/component_updater_service.h

Issue 18516010: Implemented completion pings for component updates. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/component_updater_service.h
diff --git a/chrome/browser/component_updater/component_updater_service.h b/chrome/browser/component_updater/component_updater_service.h
index de1748bdd947b259970be3bfe1423fe3bb4c4591..7125ff417534eb13c79a26355f9e274abfa3a5fd 100644
--- a/chrome/browser/component_updater/component_updater_service.h
+++ b/chrome/browser/component_updater/component_updater_service.h
@@ -11,15 +11,15 @@
#include "base/version.h"
#include "url/gurl.h"
-namespace net {
-class URLRequestContextGetter;
-}
-
namespace base {
class DictionaryValue;
class FilePath;
}
+namespace net {
+class URLRequestContextGetter;
+}
+
class ComponentPatcher;
// Component specific installers must derive from this class and implement
@@ -91,15 +91,6 @@ class ComponentUpdateService {
// Controls the component updater behavior.
class Configurator {
public:
- enum Events {
- kManifestCheck,
- kComponentUpdated,
- kManifestError,
- kNetworkError,
- kUnpackError,
- kInstallerError
- };
-
virtual ~Configurator() {}
// Delay in seconds from calling Start() to the first update check.
virtual int InitialDelay() = 0;
@@ -114,6 +105,9 @@ class ComponentUpdateService {
virtual int OnDemandDelay() = 0;
// The url that is going to be used update checks over Omaha protocol.
virtual GURL UpdateUrl() = 0;
+ // The url where the completion pings are sent. Invalid if and only if
+ // pings are disabled.
+ virtual GURL PingUrl() = 0;
// Parameters added to each url request. It can be null if none are needed.
virtual const char* ExtraRequestParams() = 0;
// How big each update request can be. Don't go above 2000.
@@ -122,10 +116,6 @@ class ComponentUpdateService {
virtual net::URLRequestContextGetter* RequestContext() = 0;
// True means that all ops are performed in this process.
virtual bool InProcess() = 0;
- // The component updater will call this function when an interesting event
- // happens. It should be used mostly as a place to add application specific
- // logging or telemetry. |extra| is |event| dependent.
- virtual void OnEvent(Events event, int extra) = 0;
// Creates a new ComponentPatcher in a platform-specific way. This is useful
// for dependency injection.
virtual ComponentPatcher* CreateComponentPatcher() = 0;

Powered by Google App Engine
This is Rietveld 408576698