Implemented completion pings for component updates.

chrome/browser/component_updater/component_updater_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_
 #define CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_
 
 #include <string>
 #include <vector>
 
 #include "base/version.h"
 #include "url/gurl.h"
 
-namespace net {
-class URLRequestContextGetter;
-}
-
 namespace base {
 class DictionaryValue;
 class FilePath;
 }
 
+namespace component_updater {
+class ComponentUpdaterServiceObserver;
+}
+
+namespace net {
+class URLRequestContextGetter;
+}
+
 class ComponentPatcher;
 
 // Component specific installers must derive from this class and implement
 // OnUpdateError() and Install(). A valid instance of this class must be
 // given to ComponentUpdateService::RegisterComponent().
 class ComponentInstaller {
  public :
   // Called by the component updater on the UI thread when there was a
   // problem unpacking or verifying the component. |error| is a non-zero
   // value which is only meaningful to the component updater.
@@ skipping 51 matching lines @@
  public:
   enum Status {
     kOk,
     kReplaced,
     kInProgress,
     kError
   };
   // Controls the component updater behavior.
   class Configurator {
    public:
-    enum Events {
-      kManifestCheck,
-      kComponentUpdated,
-      kManifestError,
-      kNetworkError,
-      kUnpackError,
-      kInstallerError
-    };
-
     virtual ~Configurator() {}
+    virtual void Init(ComponentUpdateService* cus) = 0;
     // Delay in seconds from calling Start() to the first update check.
     virtual int InitialDelay() = 0;
     // Delay in seconds to every subsequent update check. 0 means don't check.
     virtual int NextCheckDelay() = 0;
     // Delay in seconds from each task step. Used to smooth out CPU/IO usage.
     virtual int StepDelay() = 0;
     // Minimum delta time in seconds before checking again the same component.
     virtual int MinimumReCheckWait() = 0;
     // Minimum delta time in seconds before an on-demand check is allowed
     // for the same component.
     virtual int OnDemandDelay() = 0;
     // The url that is going to be used update checks over Omaha protocol.
     virtual GURL UpdateUrl() = 0;
+    // The url where the completion pings are sent. Invalid if and only if
+    // pings are disabled.
+    virtual GURL PingUrl() = 0;
     // Parameters added to each url request. It can be null if none are needed.
     virtual const char* ExtraRequestParams() = 0;
     // How big each update request can be. Don't go above 2000.
     virtual size_t UrlSizeLimit() = 0;
     // The source of contexts for all the url requests.
     virtual net::URLRequestContextGetter* RequestContext() = 0;
     // True means that all ops are performed in this process.
     virtual bool InProcess() = 0;
-    // The component updater will call this function when an interesting event
-    // happens. It should be used mostly as a place to add application specific
-    // logging or telemetry. |extra| is |event| dependent.
-    virtual void OnEvent(Events event, int extra) = 0;
     // Creates a new ComponentPatcher in a platform-specific way. This is useful
     // for dependency injection.
     virtual ComponentPatcher* CreateComponentPatcher() = 0;
     // True means that this client can handle delta updates.
     virtual bool DeltasEnabled() const = 0;
   };
 
   // Start doing update checks and installing new versions of registered
   // components after Configurator::InitialDelay() seconds.
   virtual Status Start() = 0;
@@ skipping 10 matching lines @@
   // registered component, soon. If an update or check is already in progress,
   // returns |kInProgress|. The same component cannot be checked repeatedly
   // in a short interval either (returns |kError| if so).
   // There is no guarantee that the item will actually be updated,
   // since another item may be chosen to be updated. Since there is
   // no time guarantee, there is no notification if the item is not updated.
   // However, the ComponentInstaller should know if an update succeeded
   // via the Install() hook.
   virtual Status CheckForUpdateSoon(const CrxComponent& component) = 0;
 
+  // Adds or removes observers for this class. The caller of this class
+  // still maintains ownership of the observer, and it is responsible for
+  // removing and destroying the observer when the observer is not needed.

[waffles, 2013/07/16 22:47:13]

What is the purpose of the returned status? We don't appear to check it or
return anything useful.

[Sorin Jianu, 2013/07/16 22:52:47]

To be consistent with the other methods in the interface.

+  virtual Status AddObserver(
+      component_updater::ComponentUpdaterServiceObserver* observer) = 0;
+  virtual Status RemoveObserver(
+      component_updater::ComponentUpdaterServiceObserver* observer) = 0;
+
   virtual ~ComponentUpdateService() {}
 };
 
 // Creates the component updater. You must pass a valid |config| allocated on
 // the heap which the component updater will own.
 ComponentUpdateService* ComponentUpdateServiceFactory(
     ComponentUpdateService::Configurator* config);
 
 #endif  // CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_