Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1236)

Unified Diff: src/effects/SkTestImageFilters.cpp

Issue 1851583002: Switch SkDownSampleImageFilter over to new onFilterImage interface (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Nuclear option Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/effects/SkTestImageFilters.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/effects/SkTestImageFilters.cpp
diff --git a/src/effects/SkTestImageFilters.cpp b/src/effects/SkTestImageFilters.cpp
index e9ec7c19ceb6cd80f1445835daf95c1fed08f7c8..d62fc725cc8c8e3789db9a0ab7fe6bcce5b19e49 100755
--- a/src/effects/SkTestImageFilters.cpp
+++ b/src/effects/SkTestImageFilters.cpp
@@ -7,36 +7,22 @@
#include "SkTestImageFilters.h"
#include "SkCanvas.h"
-#include "SkDevice.h"
#include "SkReadBuffer.h"
+#include "SkSpecialImage.h"
+#include "SkSpecialSurface.h"
#include "SkWriteBuffer.h"
-// Simple helper canvas that "takes ownership" of the provided device, so that
-// when this canvas goes out of scope, so will its device. Could be replaced
-// with the following:
-//
-// SkCanvas canvas(device);
-// SkAutoTUnref<SkBaseDevice> aur(device);
-//
-class OwnDeviceCanvas : public SkCanvas {
-public:
- OwnDeviceCanvas(SkBaseDevice* device) : SkCanvas(device) {
- SkSafeUnref(device);
- }
-};
-
///////////////////////////////////////////////////////////////////////////////
-bool SkDownSampleImageFilter::onFilterImageDeprecated(Proxy* proxy, const SkBitmap& src,
- const Context&,
- SkBitmap* result, SkIPoint*) const {
- SkScalar scale = fScale;
- if (scale > SK_Scalar1 || scale <= 0) {
- return false;
+sk_sp<SkSpecialImage> SkDownSampleImageFilter::onFilterImage(SkSpecialImage* source,
+ const Context& ctx,
+ SkIPoint* offset) const {
+ if (fScale > SK_Scalar1 || fScale <= 0) {
+ return nullptr;
}
- int dstW = SkScalarRoundToInt(src.width() * scale);
- int dstH = SkScalarRoundToInt(src.height() * scale);
+ int dstW = SkScalarRoundToInt(source->width() * fScale);
+ int dstH = SkScalarRoundToInt(source->height() * fScale);
if (dstW < 1) {
dstW = 1;
}
@@ -44,35 +30,54 @@ bool SkDownSampleImageFilter::onFilterImageDeprecated(Proxy* proxy, const SkBitm
dstH = 1;
}
- SkBitmap tmp;
+ sk_sp<SkSpecialImage> tmp;
// downsample
{
- SkBaseDevice* dev = proxy->createDevice(dstW, dstH);
- if (nullptr == dev) {
- return false;
+ const SkImageInfo info = SkImageInfo::MakeN32Premul(dstW, dstH);
+
+ sk_sp<SkSpecialSurface> surf(source->makeSurface(info));
+ if (!surf) {
+ return nullptr;
}
- OwnDeviceCanvas canvas(dev);
- SkPaint paint;
+ SkCanvas* canvas = surf->getCanvas();
+ SkASSERT(canvas);
+
+ canvas->clear(0x0);
+
+ SkPaint paint;
+ paint.setXfermodeMode(SkXfermode::kSrcOver_Mode);
paint.setFilterQuality(kLow_SkFilterQuality);
- canvas.scale(scale, scale);
- canvas.drawBitmap(src, 0, 0, &paint);
- tmp = dev->accessBitmap(false);
+
+ canvas->scale(fScale, fScale);
+ source->draw(canvas, 0, 0, &paint);
+
+ tmp = surf->makeImageSnapshot();
}
// upscale
{
- SkBaseDevice* dev = proxy->createDevice(src.width(), src.height());
- if (nullptr == dev) {
- return false;
+ const SkImageInfo info = SkImageInfo::MakeN32Premul(source->width(), source->height());
+
+ sk_sp<SkSpecialSurface> surf(source->makeSurface(info));
+ if (!surf) {
+ return nullptr;
}
- OwnDeviceCanvas canvas(dev);
- canvas.drawBitmapRect(tmp, SkRect::MakeIWH(src.width(), src.height()), nullptr);
- *result = dev->accessBitmap(false);
+ SkCanvas* canvas = surf->getCanvas();
+ SkASSERT(canvas);
+
+ canvas->clear(0x0);
+
+ SkPaint paint;
+ paint.setXfermodeMode(SkXfermode::kSrcOver_Mode);
+
+ canvas->scale(SkScalarInvert(fScale), SkScalarInvert(fScale));
+ tmp->draw(canvas, 0, 0, &paint);
+
+ return surf->makeImageSnapshot();
}
- return true;
}
sk_sp<SkFlattenable> SkDownSampleImageFilter::CreateProc(SkReadBuffer& buffer) {
« no previous file with comments | « include/effects/SkTestImageFilters.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698