Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1851583002:
Switch SkDownSampleImageFilter over to new onFilterImage interface (Closed)
|
Created:
4 years, 8 months ago by robertphillips Modified:
4 years, 8 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionSwitch SkDownSampleImageFilter over to new onFilterImage interface
This will slightly change the testimagefilters GM images
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1851583002
Committed: https://skia.googlesource.com/skia/+/daa9da4937b6dfc9e1047239b4afd41b1c5474d5
Committed: https://skia.googlesource.com/skia/+/33550dab45516bbcfa5ab908c5857fb382535c44
Committed: https://skia.googlesource.com/skia/+/175cf0e51b9fbb075588c4d29e7e4257cea6f4ad
Patch Set 1 #
Total comments: 2
Patch Set 2 : Address code review comments #Patch Set 3 : Fix down sample image filter bug #Patch Set 4 : Add kSrcOver_Mode #Patch Set 5 : update to ToT #Patch Set 6 : update to ToT #Patch Set 7 : Nuclear option #Messages
Total messages: 46 (24 generated)
Description was changed from ========== Switch SkDownSampleImageFilter over to new onFilterImage interface This will change BUG=skia: ========== to ========== Switch SkDownSampleImageFilter over to new onFilterImage interface This will change BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Switch SkDownSampleImageFilter over to new onFilterImage interface This will change BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Switch SkDownSampleImageFilter over to new onFilterImage interface This will slightly change the testimagefilters GM images TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
robertphillips@google.com changed reviewers: + reed@google.com, senorblanco@chromium.org, senorblanco@google.com
LGTM w/nit https://codereview.chromium.org/1851583002/diff/1/src/effects/SkTestImageFilt... File src/effects/SkTestImageFilters.cpp (right): https://codereview.chromium.org/1851583002/diff/1/src/effects/SkTestImageFilt... src/effects/SkTestImageFilters.cpp:68: canvas->scale(1.0f/fScale, 1.0f/fScale); SkScalarInvert, so it handles the scalar-is-double case more cleanly?
https://codereview.chromium.org/1851583002/diff/1/src/effects/SkTestImageFilt... File src/effects/SkTestImageFilters.cpp (right): https://codereview.chromium.org/1851583002/diff/1/src/effects/SkTestImageFilt... src/effects/SkTestImageFilters.cpp:68: canvas->scale(1.0f/fScale, 1.0f/fScale); On 2016/03/31 17:50:15, Stephen White wrote: > SkScalarInvert, so it handles the scalar-is-double case more cleanly? Done.
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851583002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from senorblanco@chromium.org Link to the patchset: https://codereview.chromium.org/1851583002/#ps20001 (title: "Address code review comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851583002/20001
Message was sent while issue was closed.
Description was changed from ========== Switch SkDownSampleImageFilter over to new onFilterImage interface This will slightly change the testimagefilters GM images TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Switch SkDownSampleImageFilter over to new onFilterImage interface This will slightly change the testimagefilters GM images TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/daa9da4937b6dfc9e1047239b4afd41b1c5474d5 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/daa9da4937b6dfc9e1047239b4afd41b1c5474d5
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1853823002/ by robertphillips@google.com. The reason for reverting is: Some images are incorrect.
Message was sent while issue was closed.
Description was changed from ========== Switch SkDownSampleImageFilter over to new onFilterImage interface This will slightly change the testimagefilters GM images TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/daa9da4937b6dfc9e1047239b4afd41b1c5474d5 ========== to ========== Switch SkDownSampleImageFilter over to new onFilterImage interface This will slightly change the testimagefilters GM images TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/daa9da4937b6dfc9e1047239b4afd41b1c5474d5 ==========
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851583002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851583002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851583002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851583002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851583002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851583002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from senorblanco@chromium.org Link to the patchset: https://codereview.chromium.org/1851583002/#ps100001 (title: "update to ToT")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851583002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851583002/100001
Message was sent while issue was closed.
Description was changed from ========== Switch SkDownSampleImageFilter over to new onFilterImage interface This will slightly change the testimagefilters GM images TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/daa9da4937b6dfc9e1047239b4afd41b1c5474d5 ========== to ========== Switch SkDownSampleImageFilter over to new onFilterImage interface This will slightly change the testimagefilters GM images TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/daa9da4937b6dfc9e1047239b4afd41b1c5474d5 Committed: https://skia.googlesource.com/skia/+/33550dab45516bbcfa5ab908c5857fb382535c44 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://skia.googlesource.com/skia/+/33550dab45516bbcfa5ab908c5857fb382535c44
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/1859533002/ by robertphillips@google.com. The reason for reverting is: changing images on bots.
Message was sent while issue was closed.
Description was changed from ========== Switch SkDownSampleImageFilter over to new onFilterImage interface This will slightly change the testimagefilters GM images TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/daa9da4937b6dfc9e1047239b4afd41b1c5474d5 Committed: https://skia.googlesource.com/skia/+/33550dab45516bbcfa5ab908c5857fb382535c44 ========== to ========== Switch SkDownSampleImageFilter over to new onFilterImage interface This will slightly change the testimagefilters GM images TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/daa9da4937b6dfc9e1047239b4afd41b1c5474d5 Committed: https://skia.googlesource.com/skia/+/33550dab45516bbcfa5ab908c5857fb382535c44 ==========
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851583002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851583002/120001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Once more into the breach
The CQ bit was checked by robertphillips@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from senorblanco@chromium.org Link to the patchset: https://codereview.chromium.org/1851583002/#ps120001 (title: "Nuclear option")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851583002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851583002/120001
Message was sent while issue was closed.
Description was changed from ========== Switch SkDownSampleImageFilter over to new onFilterImage interface This will slightly change the testimagefilters GM images TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/daa9da4937b6dfc9e1047239b4afd41b1c5474d5 Committed: https://skia.googlesource.com/skia/+/33550dab45516bbcfa5ab908c5857fb382535c44 ========== to ========== Switch SkDownSampleImageFilter over to new onFilterImage interface This will slightly change the testimagefilters GM images TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/daa9da4937b6dfc9e1047239b4afd41b1c5474d5 Committed: https://skia.googlesource.com/skia/+/33550dab45516bbcfa5ab908c5857fb382535c44 Committed: https://skia.googlesource.com/skia/+/175cf0e51b9fbb075588c4d29e7e4257cea6f4ad ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://skia.googlesource.com/skia/+/175cf0e51b9fbb075588c4d29e7e4257cea6f4ad |
