Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1851573002: VS 2015 Update 2 RTW (final) (Closed)

Created:
4 years, 8 months ago by brucedawson
Modified:
4 years, 8 months ago
Reviewers:
Nico, scottmg, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VS 2015 Update 2 RTW (final) This is the official VS 2015 Update 2 release. This includes all of the bug fixes which Chromium has been depending on. BUG=440500 Committed: https://crrev.com/21d776d93f2e432995f6076045f8183c141cd335 Cr-Commit-Position: refs/heads/master@{#384480}

Patch Set 1 #

Patch Set 2 : Adjusting landmines to force build and tests #

Patch Set 3 : Rebase? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/get_landmines.py View 1 1 chunk +1 line, -1 line 0 comments Download
M build/vs_toolchain.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
brucedawson
Not asking for review yet, just FYI for the moment. This will switch our VS ...
4 years, 8 months ago (2016-03-31 18:06:20 UTC) #2
Nico
I saw the git.bat problem too, I filed https://bugs.chromium.org/p/chromium/issues/detail?id=599455 for that.
4 years, 8 months ago (2016-03-31 19:31:44 UTC) #3
brucedawson
On 2016/03/31 19:31:44, Nico wrote: > I saw the git.bat problem too, I filed > ...
4 years, 8 months ago (2016-03-31 20:04:17 UTC) #4
brucedawson
Ready for review and landing - one spurious failure on a Linux builder but otherwise ...
4 years, 8 months ago (2016-03-31 23:30:36 UTC) #5
Nico
lgtm
4 years, 8 months ago (2016-04-01 00:59:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851573002/40001
4 years, 8 months ago (2016-04-01 00:59:49 UTC) #8
brettw
lgtm
4 years, 8 months ago (2016-04-01 02:06:49 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-01 04:09:58 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 04:11:38 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/21d776d93f2e432995f6076045f8183c141cd335
Cr-Commit-Position: refs/heads/master@{#384480}

Powered by Google App Engine
This is Rietveld 408576698