Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 1851543004: PPC: [compiler] Add relocatable pointer constants for wasm memory references. (Closed)

Created:
4 years, 8 months ago by MTBrandyberry
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [compiler] Add relocatable pointer constants for wasm memory references. Port eb5fe0df64ec0add423b2a1f6fb62d5a33dce2a5 Original commit message: Add relocatable pointers for wasm memory references that need to be updated when wasm GrowMemory is used. Code generator changes to accept relocatable constants as immediates. R=gdeepti@google.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/ba053c4620c3b91ddc540f733f8b4dd9a792bb13 Cr-Commit-Position: refs/heads/master@{#35203}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +18 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
MTBrandyberry
PTAL
4 years, 8 months ago (2016-04-01 02:52:20 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851543004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851543004/1
4 years, 8 months ago (2016-04-01 02:52:36 UTC) #3
JoranSiu
On 2016/04/01 02:52:36, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 8 months ago (2016-04-01 03:02:31 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-01 06:08:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851543004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851543004/1
4 years, 8 months ago (2016-04-01 13:12:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 13:14:05 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ba053c4620c3b91ddc540f733f8b4dd9a792bb13 Cr-Commit-Position: refs/heads/master@{#35203}
4 years, 8 months ago (2016-04-01 13:14:40 UTC) #11
MTBrandyberry
4 years, 8 months ago (2016-04-01 15:29:29 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1851823002/ by mbrandy@us.ibm.com.

The reason for reverting is: Original commit reverted..

Powered by Google App Engine
This is Rietveld 408576698