Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1851483002: Revert of Replicate to all renderers the accepted languages set by a layout test. (Closed)

Created:
4 years, 8 months ago by Łukasz Anforowicz
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@splitting-web-frame-test-client
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Replicate to all renderers the accepted languages set by a layout test. (patchset #5 id:80001 of https://codereview.chromium.org/1829253002/ ) Reason for revert: Prevents clean reverting of an earlier CL (https://codereview.chromium.org/1821923003/) that caused use after free related to color chooser. Original issue's description: > Replicate to all renderers the accepted languages set by a layout test. > > Moving |accept_languages_| from WebTestProxyBase into LayoutTestRuntimeFlags > helps to > 1) replicate the value requested by a test into all renderers > 2) prepare WebTestProxyBase to help with extraction of WebViewTestClient class. > > BUG=587175, 595089 > > Committed: https://crrev.com/305f1739ea0dc08182da9d81193b859518f31bc7 > Cr-Commit-Position: refs/heads/master@{#384089} TBR=jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=587175, 595089 Committed: https://crrev.com/1f3397f96d32c86a816c76d3f99801cf32491c04 Cr-Commit-Position: refs/heads/master@{#384267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -36 lines) Patch
M components/test_runner/layout_test_runtime_flags.h View 2 chunks +0 lines, -15 lines 0 comments Download
M components/test_runner/layout_test_runtime_flags.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/test_runner/test_runner.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/test_runner/test_runner.cc View 1 chunk +1 line, -10 lines 0 comments Download
M components/test_runner/tracked_dictionary.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/test_runner/tracked_dictionary.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/test_runner/web_test_proxy.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/test_runner/web_test_proxy.cc View 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Łukasz Anforowicz
Created Revert of Replicate to all renderers the accepted languages set by a layout test.
4 years, 8 months ago (2016-03-31 14:13:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851483002/1
4 years, 8 months ago (2016-03-31 14:13:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 14:14:26 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 14:15:51 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f3397f96d32c86a816c76d3f99801cf32491c04
Cr-Commit-Position: refs/heads/master@{#384267}

Powered by Google App Engine
This is Rietveld 408576698