Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: src/heap/store-buffer.h

Issue 1851473002: Change store buffer overflow check to not rely on the store buffer being (2*Size) aligned. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix arm64 Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/macro-assembler-arm64.cc ('k') | src/heap/store-buffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/store-buffer.h
diff --git a/src/heap/store-buffer.h b/src/heap/store-buffer.h
index 9c6eac90b5897bb02fe84bb6e360880c4c42860d..1e41ef453ea6ba38e72dd618d86dc67fe138be2b 100644
--- a/src/heap/store-buffer.h
+++ b/src/heap/store-buffer.h
@@ -18,8 +18,8 @@ namespace internal {
// code. On buffer overflow the slots are moved to the remembered set.
class StoreBuffer {
public:
- static const int kStoreBufferOverflowBit = 1 << (14 + kPointerSizeLog2);
- static const int kStoreBufferSize = kStoreBufferOverflowBit;
+ static const int kStoreBufferSize = 1 << (14 + kPointerSizeLog2);
+ static const int kStoreBufferMask = kStoreBufferSize - 1;
static const int kStoreBufferLength = kStoreBufferSize / sizeof(Address);
Michael Lippautz 2016/03/31 15:44:52 nit: kStoreBufferLength is unused. Let's remove it
ulan 2016/03/31 16:23:14 Done
static void StoreBufferOverflow(Isolate* isolate);
« no previous file with comments | « src/arm64/macro-assembler-arm64.cc ('k') | src/heap/store-buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698