Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Side by Side Diff: src/arm/macro-assembler-arm.cc

Issue 1851473002: Change store buffer overflow check to not rely on the store buffer being (2*Size) aligned. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove kStoreBufferLength Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/macro-assembler-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <limits.h> // For LONG_MIN, LONG_MAX. 5 #include <limits.h> // For LONG_MIN, LONG_MAX.
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/base/division-by-constant.h" 10 #include "src/base/division-by-constant.h"
(...skipping 720 matching lines...) Expand 10 before | Expand all | Expand 10 after
731 ExternalReference store_buffer = 731 ExternalReference store_buffer =
732 ExternalReference::store_buffer_top(isolate()); 732 ExternalReference::store_buffer_top(isolate());
733 mov(ip, Operand(store_buffer)); 733 mov(ip, Operand(store_buffer));
734 ldr(scratch, MemOperand(ip)); 734 ldr(scratch, MemOperand(ip));
735 // Store pointer to buffer and increment buffer top. 735 // Store pointer to buffer and increment buffer top.
736 str(address, MemOperand(scratch, kPointerSize, PostIndex)); 736 str(address, MemOperand(scratch, kPointerSize, PostIndex));
737 // Write back new top of buffer. 737 // Write back new top of buffer.
738 str(scratch, MemOperand(ip)); 738 str(scratch, MemOperand(ip));
739 // Call stub on end of buffer. 739 // Call stub on end of buffer.
740 // Check for end of buffer. 740 // Check for end of buffer.
741 tst(scratch, Operand(StoreBuffer::kStoreBufferOverflowBit)); 741 tst(scratch, Operand(StoreBuffer::kStoreBufferMask));
742 if (and_then == kFallThroughAtEnd) { 742 if (and_then == kFallThroughAtEnd) {
743 b(eq, &done); 743 b(ne, &done);
744 } else { 744 } else {
745 DCHECK(and_then == kReturnAtEnd); 745 DCHECK(and_then == kReturnAtEnd);
746 Ret(eq); 746 Ret(ne);
747 } 747 }
748 push(lr); 748 push(lr);
749 StoreBufferOverflowStub store_buffer_overflow(isolate(), fp_mode); 749 StoreBufferOverflowStub store_buffer_overflow(isolate(), fp_mode);
750 CallStub(&store_buffer_overflow); 750 CallStub(&store_buffer_overflow);
751 pop(lr); 751 pop(lr);
752 bind(&done); 752 bind(&done);
753 if (and_then == kReturnAtEnd) { 753 if (and_then == kReturnAtEnd) {
754 Ret(); 754 Ret();
755 } 755 }
756 } 756 }
(...skipping 3202 matching lines...) Expand 10 before | Expand all | Expand 10 after
3959 } 3959 }
3960 } 3960 }
3961 if (mag.shift > 0) mov(result, Operand(result, ASR, mag.shift)); 3961 if (mag.shift > 0) mov(result, Operand(result, ASR, mag.shift));
3962 add(result, result, Operand(dividend, LSR, 31)); 3962 add(result, result, Operand(dividend, LSR, 31));
3963 } 3963 }
3964 3964
3965 } // namespace internal 3965 } // namespace internal
3966 } // namespace v8 3966 } // namespace v8
3967 3967
3968 #endif // V8_TARGET_ARCH_ARM 3968 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/macro-assembler-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698