Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 1851463002: No need to look up Document from Element. (Closed)

Created:
4 years, 8 months ago by rune
Modified:
4 years, 8 months ago
Reviewers:
dglazkov, kochi
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

No need to look up Document from Element. Instead use the document() from StyleResolver. R=kochi@chromium.org Committed: https://crrev.com/15c8ef92a87ab24755b69d81388ae8a0ecaf9571 Cr-Commit-Position: refs/heads/master@{#384325}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851463002/1
4 years, 8 months ago (2016-03-31 13:01:41 UTC) #2
rune
ptal
4 years, 8 months ago (2016-03-31 13:01:44 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-31 14:11:29 UTC) #5
dglazkov
lgtm
4 years, 8 months ago (2016-03-31 16:24:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851463002/1
4 years, 8 months ago (2016-03-31 17:50:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 17:59:57 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 18:01:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15c8ef92a87ab24755b69d81388ae8a0ecaf9571
Cr-Commit-Position: refs/heads/master@{#384325}

Powered by Google App Engine
This is Rietveld 408576698