Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1851453002:
perf: Disable Oort Online as it is failing in most runs (Closed)
|
Created:
4 years, 8 months ago by Sami Modified:
4 years, 8 months ago Reviewers:
petrcermak CC:
chromium-reviews, telemetry-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionperf: Disable Oort Online as it is failing in most runs
BUG=599416
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
Committed: https://crrev.com/3da60d44eca3814ab3172d8afc7c7e09cfc663b4
Cr-Commit-Position: refs/heads/master@{#384258}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Tidy up. #Messages
Total messages: 19 (11 generated)
Description was changed from ========== perf: Disable Oort Online as it is failing in most runs BUG=599416 ========== to ========== perf: Disable Oort Online as it is failing in most runs BUG=599416 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
Description was changed from ========== perf: Disable Oort Online as it is failing in most runs BUG=599416 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== perf: Disable Oort Online as it is failing in most runs BUG=599416 NOTRY=true ==========
skyostil@chromium.org changed reviewers: + petrcermak@chromium.org
LGTM with one comment and remove NOTRY=true !!! (https://chromium.googlesource.com/chromium/src/+/master/tools/perf/docs/perf_...). Thanks, Petr https://codereview.chromium.org/1851453002/diff/1/tools/perf/benchmarks/oorto... File tools/perf/benchmarks/oortonline.py (right): https://codereview.chromium.org/1851453002/diff/1/tools/perf/benchmarks/oorto... tools/perf/benchmarks/oortonline.py:55: @benchmark.Disabled('win') # crbug.com/599416 I would combine the two decorators into a single one: @benchmark.Disabled('win', 'mac') # crbug.com/599416
Description was changed from ========== perf: Disable Oort Online as it is failing in most runs BUG=599416 NOTRY=true ========== to ========== perf: Disable Oort Online as it is failing in most runs BUG=599416 NOTRY=true CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
Description was changed from ========== perf: Disable Oort Online as it is failing in most runs BUG=599416 NOTRY=true CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== perf: Disable Oort Online as it is failing in most runs BUG=599416 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
On 2016/03/31 10:59:15, petrcermak wrote: > LGTM with one comment and remove NOTRY=true !!! Done. I guess sheriffing isn't about doing things like in the wild west anymore :) > https://codereview.chromium.org/1851453002/diff/1/tools/perf/benchmarks/oorto... > tools/perf/benchmarks/oortonline.py:55: @benchmark.Disabled('win') # > crbug.com/599416 > I would combine the two decorators into a single one: > > @benchmark.Disabled('win', 'mac') # crbug.com/599416 Ah, forgot about that, thanks.
The CQ bit was checked by skyostil@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from petrcermak@chromium.org Link to the patchset: https://codereview.chromium.org/1851453002/#ps20001 (title: "Tidy up.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851453002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
The CQ bit was checked by skyostil@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851453002/20001
Message was sent while issue was closed.
Description was changed from ========== perf: Disable Oort Online as it is failing in most runs BUG=599416 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== perf: Disable Oort Online as it is failing in most runs BUG=599416 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== perf: Disable Oort Online as it is failing in most runs BUG=599416 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== perf: Disable Oort Online as it is failing in most runs BUG=599416 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Committed: https://crrev.com/3da60d44eca3814ab3172d8afc7c7e09cfc663b4 Cr-Commit-Position: refs/heads/master@{#384258} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3da60d44eca3814ab3172d8afc7c7e09cfc663b4 Cr-Commit-Position: refs/heads/master@{#384258} |
