Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1851443003: Make global variable gTimeDeltaForTesting lazily created. (Closed)

Created:
4 years, 8 months ago by ckulakowski
Modified:
4 years, 8 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make global variable gTimeDeltaForTesting lazily created. It's a fix for compilation error: "declaration requires a global constructor [-Werror,-Wglobal-constructors]" BUG= Committed: https://crrev.com/fc74dbfb10190c7dffbf9c77b90ce4c45ec01403 Cr-Commit-Position: refs/heads/master@{#384724}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/banners/app_banner_data_fetcher.cc View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ckulakowski
4 years, 8 months ago (2016-04-01 08:43:44 UTC) #3
gone
lgtm
4 years, 8 months ago (2016-04-01 17:59:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851443003/1
4 years, 8 months ago (2016-04-01 21:48:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 23:51:04 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 23:53:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc74dbfb10190c7dffbf9c77b90ce4c45ec01403
Cr-Commit-Position: refs/heads/master@{#384724}

Powered by Google App Engine
This is Rietveld 408576698