Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1851433005: Add git rolling instructions directly to depot_tools. (Closed)

Created:
4 years, 8 months ago by iannucci
Modified:
4 years, 8 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add git rolling instructions directly to depot_tools. Also switches the download url to the non-deprecated gs direct download URL, and remove an ancient README.google that talked about software that's no longer distributed. R=dnj@chromium.org, agable@chromium.org, maruel@chromium.org, mmoss@chromium.org BUG=598958 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=299622

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -17 lines) Patch
D bootstrap/win/README.google View 1 chunk +0 lines, -16 lines 0 comments Download
A bootstrap/win/README.md View 1 1 chunk +66 lines, -0 lines 0 comments Download
M bootstrap/win/win_tools.bat View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
iannucci
4 years, 8 months ago (2016-04-01 02:38:45 UTC) #1
iannucci
+dnj
4 years, 8 months ago (2016-04-01 02:45:54 UTC) #3
dnj
lgtm w/ comments https://chromiumcodereview.appspot.com/1851433005/diff/1/bootstrap/win/README.md File bootstrap/win/README.md (right): https://chromiumcodereview.appspot.com/1851433005/diff/1/bootstrap/win/README.md#newcode14 bootstrap/win/README.md:14: autoupdate script `../../update_depot_tools.bat`. This, in turn, ...
4 years, 8 months ago (2016-04-01 03:00:41 UTC) #4
iannucci
https://chromiumcodereview.appspot.com/1851433005/diff/1/bootstrap/win/README.md File bootstrap/win/README.md (right): https://chromiumcodereview.appspot.com/1851433005/diff/1/bootstrap/win/README.md#newcode14 bootstrap/win/README.md:14: autoupdate script `../../update_depot_tools.bat`. This, in turn, will run On ...
4 years, 8 months ago (2016-04-01 06:10:06 UTC) #5
iannucci
4 years, 8 months ago (2016-04-01 06:11:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 299622.

Powered by Google App Engine
This is Rietveld 408576698