pkg/compiler/lib/src/js_backend/backend.dart - Issue 1851433002: Better record compile-time errors on elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 1851433002: Better record compile-time errors on elements (Closed) Base URL: https://github.com/dart-lang/sdk.git@_temporary_fletch_patches

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/backend.dart

diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart

index ae649fbf2bc0632088acab4d1c09554a6feb9063..0b0bac7015e8f986f8e8486f9b1773b03a89c00b 100644

--- a/pkg/compiler/lib/src/js_backend/backend.dart

+++ b/pkg/compiler/lib/src/js_backend/backend.dart

@@ -1567,7 +1567,7 @@ class JavaScriptBackend extends Backend {

Element element = work.element;

if (compiler.elementHasCompileTimeError(element)) {

DiagnosticMessage message =

- compiler.elementsWithCompileTimeErrors[element];

+ compiler.elementsWithCompileTimeErrors[element].last;

String messageText = message.message.computeMessage();

jsAst.LiteralString messageLiteral =

js.escapedString("Compile time error in $element: $messageText");