chrome/browser/extensions/service_worker_apitest.cc - Issue 1851423003: Make Web Push use InstanceID tokens instead of GCM registrations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/service_worker_apitest.cc

Issue 1851423003: Make Web Push use InstanceID tokens instead of GCM registrations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid4default

Patch Set: Address review comments, and rewrite following rebase (e.g. no longer depends on NestedMessagePumpA… Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java ('k') | chrome/browser/push_messaging/push_messaging_browsertest.cc » ('j') | chrome/browser/push_messaging/push_messaging_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/service_worker_apitest.cc

diff --git a/chrome/browser/extensions/service_worker_apitest.cc b/chrome/browser/extensions/service_worker_apitest.cc

index 6dddcb332f7e68798176a47d75dfb2a7c68d773b..858ec971e85b72cb853923a97f940f42833e0eec 100644

--- a/chrome/browser/extensions/service_worker_apitest.cc

+++ b/chrome/browser/extensions/service_worker_apitest.cc

@@ -731,8 +731,6 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerPushMessagingTest, OnPush) {

PushMessagingAppIdentifier app_identifier =

GetAppIdentifierForServiceWorkerRegistration(0LL, extension_url);

- ASSERT_EQ(app_identifier.app_id(), gcm_service()->last_registered_app_id());

- EXPECT_EQ("1234567890", gcm_service()->last_registered_sender_ids()[0]);

// Send a push message via gcm and expect the ServiceWorker to receive it.

ExtensionTestMessageListener push_message_listener("OK", false);