content/public/browser/push_messaging_service.cc - Issue 1851423003: Make Web Push use InstanceID tokens instead of GCM registrations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/push_messaging_service.cc

Issue 1851423003: Make Web Push use InstanceID tokens instead of GCM registrations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid4default

Patch Set: Fix GN/GYP Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/push_messaging/push_messaging_service_unittest.cc ('K') | « content/public/browser/push_messaging_service.h ('k') | content/public/test/test_browser_thread_bundle.h » ('j') | content/public/test/test_browser_thread_bundle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/push_messaging_service.cc

diff --git a/content/public/browser/push_messaging_service.cc b/content/public/browser/push_messaging_service.cc

index b345f9d2cdad29532af62cb22f6450b2a39e569f..359170b60a8de7d40ef1b950d7dc0eeb3da2dd7d 100644

--- a/content/public/browser/push_messaging_service.cc

+++ b/content/public/browser/push_messaging_service.cc

@@ -127,22 +127,6 @@ void PushMessagingService::SetNotificationsShownByLastFewPushes(

}

// static

-void PushMessagingService::GetSenderId(BrowserContext* browser_context,

- const GURL& origin,

- int64_t service_worker_registration_id,

- const StringCallback& callback) {

- DCHECK_CURRENTLY_ON(BrowserThread::UI);

- BrowserThread::PostTask(

- BrowserThread::IO,

- FROM_HERE,

- base::Bind(&GetUserDataOnIO,

- GetServiceWorkerContext(browser_context, origin),

- service_worker_registration_id,

- kPushSenderIdServiceWorkerKey,

- callback));

-// static

void PushMessagingService::ClearPushSubscriptionID(

BrowserContext* browser_context,

const GURL& origin,