Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2037)

Unified Diff: chrome/browser/push_messaging/push_messaging_service_factory.cc

Issue 1851423003: Make Web Push use InstanceID tokens instead of GCM registrations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid4default
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/push_messaging/push_messaging_service_factory.cc
diff --git a/chrome/browser/push_messaging/push_messaging_service_factory.cc b/chrome/browser/push_messaging/push_messaging_service_factory.cc
index a0767551fdb44e81768f4ad41839d23b7f675427..711294e918d560e4f6ee3c667e1e3b058ca06c11 100644
--- a/chrome/browser/push_messaging/push_messaging_service_factory.cc
+++ b/chrome/browser/push_messaging/push_messaging_service_factory.cc
@@ -12,20 +12,28 @@
#include "chrome/browser/profiles/incognito_helpers.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/push_messaging/push_messaging_service_impl.h"
-#include "chrome/browser/services/gcm/fake_gcm_profile_service.h"
#include "chrome/browser/services/gcm/gcm_profile_service_factory.h"
+#include "chrome/browser/services/gcm/instance_id/instance_id_profile_service.h"
+#include "chrome/browser/services/gcm/instance_id/instance_id_profile_service_factory.h"
#include "components/keyed_service/content/browser_context_dependency_manager.h"
// static
PushMessagingServiceImpl* PushMessagingServiceFactory::GetForProfile(
- content::BrowserContext* profile) {
+ content::BrowserContext* context) {
// The Push API is not currently supported in incognito mode.
// See https://crbug.com/401439.
- if (profile->IsOffTheRecord())
- return NULL;
+ if (context->IsOffTheRecord())
+ return nullptr;
+
+ if (!instance_id::InstanceIDProfileService::IsInstanceIDEnabled(
+ Profile::FromBrowserContext(context))) {
+ LOG(WARNING) << "PushMessagingService could not be built because "
+ "InstanceID is unexpectedly disabled";
+ return nullptr;
+ }
return static_cast<PushMessagingServiceImpl*>(
- GetInstance()->GetServiceForBrowserContext(profile, true));
+ GetInstance()->GetServiceForBrowserContext(context, true));
}
// static
@@ -39,6 +47,7 @@ PushMessagingServiceFactory::PushMessagingServiceFactory()
BrowserContextDependencyManager::GetInstance()) {
DependsOn(BudgetManagerFactory::GetInstance());
DependsOn(gcm::GCMProfileServiceFactory::GetInstance());
+ DependsOn(instance_id::InstanceIDProfileServiceFactory::GetInstance());
DependsOn(HostContentSettingsMapFactory::GetInstance());
DependsOn(PermissionManagerFactory::GetInstance());
}

Powered by Google App Engine
This is Rietveld 408576698