chrome/browser/push_messaging/push_messaging_app_identifier.h - Issue 1851423003: Make Web Push use InstanceID tokens instead of GCM registrations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_app_identifier.h

Issue 1851423003: Make Web Push use InstanceID tokens instead of GCM registrations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid4default

Patch Set: Rebase (remove force_subtype_for_app_id) Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/service_worker_apitest.cc ('K') | « chrome/browser/extensions/service_worker_apitest.cc ('k') | chrome/browser/push_messaging/push_messaging_app_identifier.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/push_messaging/push_messaging_app_identifier.h

diff --git a/chrome/browser/push_messaging/push_messaging_app_identifier.h b/chrome/browser/push_messaging/push_messaging_app_identifier.h

index 5e8e1a707d636cb090ca659ccbd660367311db0a..6b2d9c17e82e540ee6742fd53111c83ebfc12b82 100644

--- a/chrome/browser/push_messaging/push_messaging_app_identifier.h

+++ b/chrome/browser/push_messaging/push_messaging_app_identifier.h

@@ -34,6 +34,10 @@ class PushMessagingAppIdentifier {

// Register profile-specific prefs.

static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);

+ // Returns whether the modern InstanceID API should be used with this app_id

+ // (rather than legacy GCM registration).

+ static bool UseInstanceID(const std::string& app_id);

// Generates a new app identifier, with partially random app_id.

static PushMessagingAppIdentifier Generate(

const GURL& origin,