Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: base/task_scheduler/scheduler_thread_pool.cc

Issue 1851403003: TaskScheduler [8] SEQUENCED TaskRunners in SchedulerThreadPool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@threadpool
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/scheduler_thread_pool.cc
diff --git a/base/task_scheduler/scheduler_thread_pool.cc b/base/task_scheduler/scheduler_thread_pool.cc
index cc62728ecd5bf62557760f831d1af09baddf17dc..c43b1d747d888961a3bafcb7cb07a2487c53ce7f 100644
--- a/base/task_scheduler/scheduler_thread_pool.cc
+++ b/base/task_scheduler/scheduler_thread_pool.cc
@@ -11,6 +11,7 @@
#include "base/lazy_instance.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h"
+#include "base/sequenced_task_runner.h"
#include "base/task_scheduler/utils.h"
#include "base/threading/thread_local.h"
@@ -58,6 +59,50 @@ class SchedulerParallelTaskRunner : public TaskRunner {
DISALLOW_COPY_AND_ASSIGN(SchedulerParallelTaskRunner);
};
+// A task runner that runs tasks with the SEQUENCED ExecutionMode.
+class SchedulerSequencedTaskRunner : public SequencedTaskRunner {
+ public:
+ // Constructs a SchedulerParallelTaskRunner which can be used to post tasks so
+ // long as |executor| is alive.
+ // TODO(robliao): Find a concrete way to manage |executor|'s memory.
+ SchedulerSequencedTaskRunner(const TaskTraits& traits,
+ TaskTracker* task_tracker,
+ SchedulerTaskExecutor* executor)
+ : traits_(traits), task_tracker_(task_tracker), executor_(executor) {}
+
+ // SequencedTaskRunner:
+ bool PostDelayedTask(const tracked_objects::Location& from_here,
+ const Closure& closure,
+ TimeDelta delay) override {
+ // Post the task as part of |sequence|.
+ return PostTaskToExecutor(from_here, closure, traits_, delay, sequence_,
+ executor_, task_tracker_);
+ }
+
+ bool PostNonNestableDelayedTask(const tracked_objects::Location& from_here,
+ const Closure& closure,
+ base::TimeDelta delay) override {
+ // Tasks are never nested within the task scheduler.
+ return PostDelayedTask(from_here, closure, delay);
+ }
+
+ bool RunsTasksOnCurrentThread() const override {
+ return tls_current_thread_pool.Get().Get() == executor_;
+ }
+
+ private:
+ ~SchedulerSequencedTaskRunner() override = default;
+
+ // Sequence for all Tasks posted through this TaskRunner.
+ const scoped_refptr<Sequence> sequence_ = new Sequence;
+
+ const TaskTraits traits_;
+ TaskTracker* const task_tracker_;
+ SchedulerTaskExecutor* const executor_;
+
+ DISALLOW_COPY_AND_ASSIGN(SchedulerSequencedTaskRunner);
+};
+
} // namespace
class SchedulerThreadPool::SchedulerWorkerThreadDelegateImpl
@@ -108,8 +153,11 @@ scoped_refptr<TaskRunner> SchedulerThreadPool::CreateTaskRunnerWithTraits(
new SchedulerParallelTaskRunner(traits, task_tracker_, this));
case ExecutionMode::SEQUENCED:
+ return make_scoped_refptr(
+ new SchedulerSequencedTaskRunner(traits, task_tracker_, this));
+
case ExecutionMode::SINGLE_THREADED:
- // TODO(fdoray): Support SEQUENCED and SINGLE_THREADED TaskRunners.
+ // TODO(fdoray): Support SINGLE_THREADED TaskRunners.
NOTREACHED();
return nullptr;
}

Powered by Google App Engine
This is Rietveld 408576698