Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1851393003: Remove max width on new tab page layout. (Closed)

Created:
4 years, 8 months ago by PEConn
Modified:
4 years, 8 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove max width on new tab page layout. The max width seems to be unnecessary, and it prevents the new tab page being properly aligned when NTPSnippets are enabled. BUG=596415 Committed: https://crrev.com/09cc773d5a8c979839c06affbe1343a8eaf3f176 Cr-Commit-Position: refs/heads/master@{#385141}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/android/java/res/layout/new_tab_page_layout.xml View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
PEConn
PTAL - you can find screenshots here: http://imgur.com/a/zY9BN Do you agree that the maxWidth is ...
4 years, 8 months ago (2016-04-04 11:58:42 UTC) #2
PEConn
PTAL - you can find screenshots here: http://imgur.com/a/zY9BN Do you agree that the maxWidth is ...
4 years, 8 months ago (2016-04-04 11:58:43 UTC) #3
newt (away)
lgtm I believe the BoundedLinearLayout was needed before we added to code to limit the ...
4 years, 8 months ago (2016-04-04 18:46:40 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851393003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851393003/20001
4 years, 8 months ago (2016-04-05 08:40:45 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 09:18:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851393003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851393003/20001
4 years, 8 months ago (2016-04-05 09:19:13 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 09:23:56 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 09:25:28 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/09cc773d5a8c979839c06affbe1343a8eaf3f176
Cr-Commit-Position: refs/heads/master@{#385141}

Powered by Google App Engine
This is Rietveld 408576698