Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1851373002: convert //apps to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by Mostyn Bramley-Moore
Modified:
4 years, 8 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

convert //apps to std::unique_ptr BUG=554298 Committed: https://crrev.com/ecb4a22b939cdcd3e022ee2c452dd7f866d1dfb5 Cr-Commit-Position: refs/heads/master@{#384853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -18 lines) Patch
M apps/custom_launcher_page_contents.h View 3 chunks +8 lines, -6 lines 0 comments Download
M apps/custom_launcher_page_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M apps/launcher.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M apps/saved_files_service.h View 2 chunks +3 lines, -2 lines 0 comments Download
M apps/saved_files_service.cc View 5 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851373002/1
4 years, 8 months ago (2016-04-03 19:36:24 UTC) #2
Mostyn Bramley-Moore
@Marijn: please take a look.
4 years, 8 months ago (2016-04-03 20:02:45 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-03 20:32:19 UTC) #6
Marijn Kruisselbrink
lgtm
4 years, 8 months ago (2016-04-04 02:29:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851373002/1
4 years, 8 months ago (2016-04-04 06:03:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 06:08:12 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 06:09:34 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ecb4a22b939cdcd3e022ee2c452dd7f866d1dfb5
Cr-Commit-Position: refs/heads/master@{#384853}

Powered by Google App Engine
This is Rietveld 408576698