Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3329)

Unified Diff: chrome/browser/services/gcm/gcm_profile_service.cc

Issue 185133008: [GCM] Only allow the senders that the application is currently registered for (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updates based on code reviews Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/services/gcm/gcm_profile_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/services/gcm/gcm_profile_service.cc
diff --git a/chrome/browser/services/gcm/gcm_profile_service.cc b/chrome/browser/services/gcm/gcm_profile_service.cc
index c215192c8df17f593250d6d4f9d6306a0d3b5f73..fbd7ddc97f7ad5a44966d701f0681cfbef3e3106 100644
--- a/chrome/browser/services/gcm/gcm_profile_service.cc
+++ b/chrome/browser/services/gcm/gcm_profile_service.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/services/gcm/gcm_profile_service.h"
+#include <algorithm>
#include <string>
#include <vector>
@@ -912,6 +913,16 @@ void GCMProfileService::MessageReceived(const std::string& app_id,
if (username_.empty())
return;
+ RegistrationInfoMap::iterator iter = registration_info_map_.find(app_id);
+ // Dropping the message when application does not have a registration entry
jianli 2014/03/05 20:46:31 nit: move the comment above the previous line.
+ // or the app is not registered for the sender of the message.
+ if (iter == registration_info_map_.end() ||
+ std::find(iter->second.sender_ids.begin(),
+ iter->second.sender_ids.end(),
+ message.sender_id) == iter->second.sender_ids.end()) {
+ return;
+ }
+
GetEventRouter(app_id)->OnMessage(app_id, message);
}
« no previous file with comments | « no previous file | chrome/browser/services/gcm/gcm_profile_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698