[GCM] Only allow the senders that the application is currently registered for

chrome/browser/services/gcm/gcm_profile_service.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/services/gcm/gcm_profile_service.h"
 
 #include <string>
 #include <vector>
 
 #include "base/base64.h"
@@ skipping 894 matching lines @@
 }
 
 void GCMProfileService::MessageReceived(const std::string& app_id,
                                         GCMClient::IncomingMessage message) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
 
   // Drop the event if signed out.
   if (username_.empty())
     return;
 
-  GetEventRouter(app_id)->OnMessage(app_id, message);
+  RegistrationInfoMap::iterator info_iter = registration_info_map_.find(app_id);
+  if (info_iter == registration_info_map_.end())
+    return;
+
+  for (std::vector<std::string>::const_iterator iter =

[jianli, 2014/03/05 01:33:02]

nit: Please add a comment like:
  // Drop the message that is from unregistered sender.

Also, it seems that you can use std::find() to simplify the code.

[fgorski, 2014/03/05 19:30:22]

Done.

+           info_iter->second.sender_ids.begin();
+       iter != info_iter->second.sender_ids.end();
+       ++iter) {
+    if (*iter == message.sender_id) {
+      GetEventRouter(app_id)->OnMessage(app_id, message);
+      return;
+    }
+  }
 }
 
 void GCMProfileService::MessagesDeleted(const std::string& app_id) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
 
   // Drop the event if signed out.
   if (username_.empty())
     return;
 
   GetEventRouter(app_id)->OnMessagesDeleted(app_id);
@@ skipping 143 matching lines @@
 
   return true;
 }
 
 // static
 const char* GCMProfileService::GetPersistentRegisterKeyForTesting() {
   return kRegistrationKey;
 }
 
 }  // namespace gcm