[CSS Shapes] Serialize circle/ellipse positions

[CSS Shapes] Serialize circle/ellipse positions

Circle/ellipse positions should always be present when serialized, and should
only have the 2 or 4-valued form. Keywords are converted to percentages
and simplified where possible. This patch adds some additional processing
that converts the parsed position into the serialized format, before
converting it to text. See http://dev.w3.org/csswg/css-shapes/#basic-shape-serialization.

Ported from:
https://bugs.webkit.org/show_bug.cgi?id=129404
https://bugs.webkit.org/show_bug.cgi?id=129726

BUG=322165
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168876

[rwlbuis, 2014-03-05 23:20:03]

The circle part of this has gone into WebKit
https://bugs.webkit.org/show_bug.cgi?id=129404 and the ellipse part (tiny patch
on top) should go in soon (https://bugs.webkit.org/show_bug.cgi?id=129700).

[rwlbuis, 2014-03-10 19:20:35]

On 2014/03/05 23:20:03, rwlbuis wrote:
> The circle part of this has gone into WebKit
> https://bugs.webkit.org/show_bug.cgi?id=129404 and the ellipse part (tiny
patch
> on top) should go in soon (https://bugs.webkit.org/show_bug.cgi?id=129700).

They are both in now.

[Bear Travis, 2014-03-10 22:56:46]

The code lgtm, fwiw, though I think the test mentioned above may need tweaking.

https://codereview.chromium.org/185133006/diff/40001/LayoutTests/animations/i...
File LayoutTests/animations/interpolation/shape-outside-expected.txt (right):

https://codereview.chromium.org/185133006/diff/40001/LayoutTests/animations/i...
LayoutTests/animations/interpolation/shape-outside-expected.txt:44: FAIL:
shape-outside from [circle(20% at right 10% bottom 20px)] to [circle(30% at
right 20% bottom 30px)] was [circle(25% at calc(((100% - 10%) * 0.5) + ((100% -
20%) * 0.5)) calc(((100% - 20px) * 0.5) + ((100% - 30px) * 0.5)))] at 0.5,
expected [circle(25% at right 15% bottom 25px)] (parsed as [circle(25% at left
85% bottom 25px)])
I think this test needs to be adjusted (though it would still fail). The
expected circle would be:
circle(25% at left 85% bottom 25px)
And I hope that would remove the extra text for this text.

Is it possible to make such an adjustment?

[rwlbuis, 2014-03-10 23:17:26]

On 2014/03/10 22:56:46, Bear Travis wrote:
> The code lgtm, fwiw, though I think the test mentioned above may need
tweaking.
> 
>
https://codereview.chromium.org/185133006/diff/40001/LayoutTests/animations/i...
> File LayoutTests/animations/interpolation/shape-outside-expected.txt (right):
> 
>
https://codereview.chromium.org/185133006/diff/40001/LayoutTests/animations/i...
> LayoutTests/animations/interpolation/shape-outside-expected.txt:44: FAIL:
> shape-outside from [circle(20% at right 10% bottom 20px)] to [circle(30% at
> right 20% bottom 30px)] was [circle(25% at calc(((100% - 10%) * 0.5) + ((100%
-
> 20%) * 0.5)) calc(((100% - 20px) * 0.5) + ((100% - 30px) * 0.5)))] at 0.5,
> expected [circle(25% at right 15% bottom 25px)] (parsed as [circle(25% at left
> 85% bottom 25px)])
> I think this test needs to be adjusted (though it would still fail). The
> expected circle would be:
> circle(25% at left 85% bottom 25px)
> And I hope that would remove the extra text for this text.
> 
> Is it possible to make such an adjustment?

Done!

[Bear Travis, 2014-03-10 23:18:29]

> Is it possible to make such an adjustment?

Thanks for the fixup!

[eseidel, 2014-03-10 23:23:27]

lgtm

[commit-bot: I haz the power, 2014-03-10 23:23:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/185133006/80001

[commit-bot: I haz the power, 2014-03-10 23:33:11]

Change committed as 168876