Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2883)

Unified Diff: chrome/browser/ui/android/context_menu_helper.cc

Issue 185133005: Move referrer stripping into GURL::GetAsReferrer(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Switch over the Android ContextMenuHelper. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/context_menu_helper.cc
diff --git a/chrome/browser/ui/android/context_menu_helper.cc b/chrome/browser/ui/android/context_menu_helper.cc
index ef9dbe6942fea21d8c9ef9bde48167a56827b0bc..a5db63633d49deb7dfd8f23fb3b30e031a4fab93 100644
--- a/chrome/browser/ui/android/context_menu_helper.cc
+++ b/chrome/browser/ui/android/context_menu_helper.cc
@@ -66,8 +66,8 @@ void ContextMenuHelper::SetPopulator(jobject jpopulator) {
base::android::ScopedJavaLocalRef<jobject>
ContextMenuHelper::CreateJavaContextMenuParams(
const content::ContextMenuParams& params) {
- GURL sanitizedReferrer = SanitizeReferrer(
- params.frame_url.is_empty() ? params.page_url : params.frame_url);
+ GURL sanitizedReferrer = (params.frame_url.is_empty() ?
+ params.page_url : params.frame_url).GetAsReferrer();
JNIEnv* env = base::android::AttachCurrentThread();
base::android::ScopedJavaLocalRef<jobject> jmenu_info =
@@ -95,19 +95,6 @@ ContextMenuHelper::CreateJavaContextMenuParams(
return jmenu_info;
}
-GURL ContextMenuHelper::SanitizeReferrer(const GURL& referring_url) {
- // This mirrors sanitization done on Desktop in RenderViewContextMenu.
- if (referring_url.is_valid() && (referring_url.has_ref() ||
- referring_url.has_username() || referring_url.has_password())) {
- GURL::Replacements referrer_mods;
- referrer_mods.ClearRef();
- referrer_mods.ClearUsername();
- referrer_mods.ClearPassword();
- return referring_url.ReplaceComponents(referrer_mods);
- }
- return referring_url;
-}
-
void ContextMenuHelper::OnCustomItemSelected(JNIEnv* env,
jobject obj,
jint action) {

Powered by Google App Engine
This is Rietveld 408576698