Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: net/url_request/url_request.cc

Issue 185133005: Move referrer stripping into GURL::GetAsReferrer(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request.cc
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc
index 58697a2faaf3979412bec901d895cb117f510bce..cee0b9cbac83d78c427ad3d1a369f3f482481acf 100644
--- a/net/url_request/url_request.cc
+++ b/net/url_request/url_request.cc
@@ -588,21 +588,12 @@ std::string URLRequest::ComputeMethodForRedirect(
void URLRequest::SetReferrer(const std::string& referrer) {
DCHECK(!is_pending_);
- referrer_ = referrer;
// Ensure that we do not send URL fragment, username and password
// fields in the referrer.
GURL referrer_url(referrer);
UMA_HISTOGRAM_BOOLEAN("Net.URLRequest_SetReferrer_IsEmptyOrValid",
referrer_url.is_empty() || referrer_url.is_valid());
- if (referrer_url.is_valid() && (referrer_url.has_ref() ||
- referrer_url.has_username() || referrer_url.has_password())) {
- GURL::Replacements referrer_mods;
- referrer_mods.ClearRef();
- referrer_mods.ClearUsername();
- referrer_mods.ClearPassword();
- referrer_url = referrer_url.ReplaceComponents(referrer_mods);
- referrer_ = referrer_url.spec();
- }
+ referrer_ = referrer_url.GetAsReferrer().spec();
}
void URLRequest::set_referrer_policy(ReferrerPolicy referrer_policy) {

Powered by Google App Engine
This is Rietveld 408576698