Move referrer stripping into GURL::GetAsReferrer().

Move referrer stripping into GURL::GetAsReferrer().

This patch moves the code that removes username, password and ref parts
of the url from http referrers into GURL::GetAsReferrer().

BUG=340295
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258392

[ppi, 2014-03-04 17:11:57]

Hi Brett,

In order to get http referrers working for context-menu navigations on Android I
will need this logic to be run around
chrome/browser/ui/android/context_menu_helper.cc .

Instead of making a third copy, I thought about extracting it into a helper
method in GURL.

Please take a look and let me know wdyt!

[brettw, 2014-03-07 18:08:10]

lgtm

https://codereview.chromium.org/185133005/diff/1/url/gurl.cc
File url/gurl.cc (right):

https://codereview.chromium.org/185133005/diff/1/url/gurl.cc#newcode325
url/gurl.cc:325: (!has_ref() && !has_username() && !has_password()))
You can just put the first ( on this line right under the ! on the previous
line.

[ppi, 2014-03-13 19:33:24]

Thanks, Brett!

Adding Ted for chrome/browser/ui/android and Gavin for net/.

https://codereview.chromium.org/185133005/diff/1/url/gurl.cc
File url/gurl.cc (right):

https://codereview.chromium.org/185133005/diff/1/url/gurl.cc#newcode325
url/gurl.cc:325: (!has_ref() && !has_username() && !has_password()))
On 2014/03/07 18:08:10, brettw wrote:
> You can just put the first ( on this line right under the ! on the previous
> line.

Done.

[Ted C, 2014-03-13 20:09:01]

android - lgtm

[Ted C, 2014-03-13 20:09:02]

android - lgtm

[gavinp, 2014-03-17 10:51:35]

LGTM, although please consider my suggestion about the comment.

https://codereview.chromium.org/185133005/diff/50001/net/url_request/url_requ...
File net/url_request/url_request.cc (right):

https://codereview.chromium.org/185133005/diff/50001/net/url_request/url_requ...
net/url_request/url_request.cc:611: // Ensure that we do not send URL fragment,
username and password
This comment is now subsumed by the definition of GetAsReferrer(), so perhaps we
can remove it?

[ppi, 2014-03-20 10:50:55]

Thanks!

https://codereview.chromium.org/185133005/diff/50001/net/url_request/url_requ...
File net/url_request/url_request.cc (right):

https://codereview.chromium.org/185133005/diff/50001/net/url_request/url_requ...
net/url_request/url_request.cc:611: // Ensure that we do not send URL fragment,
username and password
On 2014/03/17 10:51:35, gavinp wrote:
> This comment is now subsumed by the definition of GetAsReferrer(), so perhaps
we
> can remove it?

Done.

[ppi, 2014-03-20 10:52:25]

The CQ bit was checked by ppi@chromium.org

[commit-bot: I haz the power, 2014-03-20 10:52:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ppi@chromium.org/185133005/90001

[commit-bot: I haz the power, 2014-03-20 12:19:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 12:19:50]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[ppi, 2014-03-20 12:20:29]

The CQ bit was checked by ppi@chromium.org

[commit-bot: I haz the power, 2014-03-20 12:20:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ppi@chromium.org/185133005/90001

[commit-bot: I haz the power, 2014-03-20 12:27:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 12:27:28]

Try jobs failed on following builders:
  tryserver.chromium on mac_chromium_rel

[ppi, 2014-03-20 12:31:36]

The CQ bit was checked by ppi@chromium.org

[commit-bot: I haz the power, 2014-03-20 12:31:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ppi@chromium.org/185133005/90001

[commit-bot: I haz the power, 2014-03-20 13:47:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 13:47:50]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[ppi, 2014-03-20 14:29:47]

The CQ bit was checked by ppi@chromium.org

[commit-bot: I haz the power, 2014-03-20 14:30:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ppi@chromium.org/185133005/110001

[commit-bot: I haz the power, 2014-03-20 18:17:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 18:17:00]

Retried try job too often on win_rel for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[ppi, 2014-03-20 19:06:32]

The CQ bit was checked by ppi@chromium.org

[commit-bot: I haz the power, 2014-03-20 19:13:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ppi@chromium.org/185133005/110001

[commit-bot: I haz the power, 2014-03-20 20:27:26]

Change committed as 258392