third_party/WebKit/public/platform/modules/indexeddb/WebIDBFactory.h - Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/indexeddb/WebIDBFactory.h

Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check the |callbacks| for nullptr and use explicit delete. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabaseCallbacks.h ('k') | third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/indexeddb/WebIDBFactory.h

diff --git a/third_party/WebKit/public/platform/modules/indexeddb/WebIDBFactory.h b/third_party/WebKit/public/platform/modules/indexeddb/WebIDBFactory.h

index 25ead72c203f581c2dc3e71fd5cc70e07060714b..1cb96a0c4a255d025c5a93a6f595989bb7af4e5f 100644

--- a/third_party/WebKit/public/platform/modules/indexeddb/WebIDBFactory.h

+++ b/third_party/WebKit/public/platform/modules/indexeddb/WebIDBFactory.h

@@ -42,9 +42,9 @@ class WebIDBFactory {

public:

virtual ~WebIDBFactory() { }

- virtual void getDatabaseNames(WebIDBCallbacks* callbacks, const WebSecurityOrigin&) { BLINK_ASSERT_NOT_REACHED(); }

- virtual void open(const WebString& name, long long version, long long transactionId, WebIDBCallbacks* callbacks, WebIDBDatabaseCallbacks* databaseCallbacks, const WebSecurityOrigin&) { BLINK_ASSERT_NOT_REACHED(); }

- virtual void deleteDatabase(const WebString& name, WebIDBCallbacks* callbacks, const WebSecurityOrigin&) { BLINK_ASSERT_NOT_REACHED(); }

+ virtual void getDatabaseNames(WebIDBCallbacks*, const WebSecurityOrigin&) = 0;

+ virtual void open(const WebString& name, long long version, long long transactionId, WebIDBCallbacks*, WebIDBDatabaseCallbacks*, const WebSecurityOrigin&) = 0;

+ virtual void deleteDatabase(const WebString& name, WebIDBCallbacks*, const WebSecurityOrigin&) = 0;

};

} // namespace blink