third_party/WebKit/Source/web/tests/VisualViewportTest.cpp - Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check the |callbacks| for nullptr and use explicit delete. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

index b400edc6827a10b9c60692b6e61f5a51fa869246..c166d8d214e91fc1cd26caf4e9a94cc9d57eb04c 100644

--- a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

+++ b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

@@ -1010,7 +1010,7 @@ TEST_P(ParameterizedVisualViewportTest, TestWebViewResizeCausesViewportConstrain

EXPECT_TRUE(navbar->needsLayout());

}

-class MockWebFrameClient : public WebFrameClient {

+class MockWebFrameClient : public FrameTestHelpers::TestWebFrameClient {

public:

MOCK_METHOD1(showContextMenu, void(const WebContextMenuData&));

MOCK_METHOD1(didChangeScrollOffset, void(WebLocalFrame*));

« no previous file with comments | « third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp ('k') | third_party/WebKit/public/platform/DEPS » ('j') | no next file with comments »