third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp - Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check the |callbacks| for nullptr and use explicit delete. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/WebSpeechGrammar.cpp ('k') | third_party/WebKit/Source/web/tests/FrameLoaderClientImplTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp b/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

index 62bc2d641762db943726a50225387fd58615e5c5..d77df7fe0a8c249d522fed99316807db8233cd8d 100644

--- a/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

+++ b/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

@@ -61,11 +61,6 @@ private:

WebNavigationPolicy* m_target;

};

-class TestWebFrameClient : public WebFrameClient {

-public:

- ~TestWebFrameClient() override { }

-};

} // anonymous namespace

class GetNavigationPolicyTest : public testing::Test {

@@ -116,7 +111,7 @@ protected:

TestWebViewClient m_webViewClient;

WebViewImpl* m_webView;

WebFrame* m_mainFrame;

- TestWebFrameClient m_webFrameClient;

+ FrameTestHelpers::TestWebFrameClient m_webFrameClient;

Persistent<ChromeClientImpl> m_chromeClientImpl;

};