third_party/WebKit/Source/web/LinkHighlightImplTest.cpp - Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/LinkHighlightImplTest.cpp

Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check the |callbacks| for nullptr and use explicit delete. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/exported/WebCommon.cpp ('k') | third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/LinkHighlightImplTest.cpp

diff --git a/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp b/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp

index 565f13258596c9eb56beab6762961890332bc1ae..fb9f2228eeccc043c4a0f9e07fdc07b7a61ce7cb 100644

--- a/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp

+++ b/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp

@@ -109,13 +109,9 @@ TEST(LinkHighlightImplTest, verifyWebViewImplIntegration)

namespace {

-class FakeWebFrameClient : public WebFrameClient {

- // To make the destructor public.

-};

class FakeCompositingWebViewClient : public FrameTestHelpers::TestWebViewClient {

public:

- FakeWebFrameClient m_fakeWebFrameClient;

+ FrameTestHelpers::TestWebFrameClient m_fakeWebFrameClient;

};

FakeCompositingWebViewClient* compositingWebViewClient()