Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: third_party/WebKit/public/web/WebFrameClient.h

Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Implement checkIfAudioSinkExistsAndIsAuthorized in WebFrameClient. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebFrameClient.h
diff --git a/third_party/WebKit/public/web/WebFrameClient.h b/third_party/WebKit/public/web/WebFrameClient.h
index 5fd21c9dc1ceb855c01633ff06731e3ecf9f89b1..89ff3aa91b2cb837744e957ac303c168e0e8650f 100644
--- a/third_party/WebKit/public/web/WebFrameClient.h
+++ b/third_party/WebKit/public/web/WebFrameClient.h
@@ -55,6 +55,7 @@
#include "public/platform/WebStorageQuotaType.h"
#include "public/platform/WebURLError.h"
#include "public/platform/WebURLRequest.h"
+#include <memory>
#include <v8.h>
namespace blink {
@@ -721,7 +722,11 @@ public:
// Checks that the given audio sink exists and is authorized. The result is provided via the callbacks.
// This method takes ownership of the callbacks pointer.
- virtual void checkIfAudioSinkExistsAndIsAuthorized(const WebString& sinkId, const WebSecurityOrigin&, WebSetSinkIdCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
+ virtual void checkIfAudioSinkExistsAndIsAuthorized(const WebString& sinkId, const WebSecurityOrigin&, WebSetSinkIdCallbacks* callbacks)
+ {
+ std::unique_ptr<WebSetSinkIdCallbacks> callback;
+ callback->onError(WebSetSinkIdError::NotSupported);
esprehn 2016/04/06 20:02:02 this doesn't really do anything I think? You don'
liberato (no reviews please) 2016/04/06 21:02:34 i think that "std::unique... callback(callbacks)"
kotenkov 2016/04/07 06:03:28 You are correct. Okay, I've changed it to explicit
+ }
protected:
virtual ~WebFrameClient() { }

Powered by Google App Engine
This is Rietveld 408576698