Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: third_party/WebKit/public/platform/WebProcessMemoryDump.h

Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebProcessMemoryDump.h
diff --git a/third_party/WebKit/public/platform/WebProcessMemoryDump.h b/third_party/WebKit/public/platform/WebProcessMemoryDump.h
index 432ab947b0d9a0d11303de1f9e7ade675a2b647f..91af65debc3064910deefd46d1fb0816ac5794ea 100644
--- a/third_party/WebKit/public/platform/WebProcessMemoryDump.h
+++ b/third_party/WebKit/public/platform/WebProcessMemoryDump.h
@@ -44,20 +44,20 @@ public:
// addOwnershipEdge(). If omitted, it will be automatically generated.
virtual WebMemoryAllocatorDump* createMemoryAllocatorDump(const WebString& absoluteName, WebMemoryAllocatorDumpGuid guid)
{
- BLINK_ASSERT_NOT_REACHED();
+ NOTREACHED();
return nullptr;
}
virtual WebMemoryAllocatorDump* createMemoryAllocatorDump(const WebString& absoluteName)
{
- BLINK_ASSERT_NOT_REACHED();
+ NOTREACHED();
return nullptr;
}
// Gets a previously created MemoryAllocatorDump given its name.
virtual WebMemoryAllocatorDump* getMemoryAllocatorDump(const WebString& absoluteName) const
{
- BLINK_ASSERT_NOT_REACHED();
+ NOTREACHED();
return nullptr;
}
@@ -66,7 +66,7 @@ public:
// method returns.
virtual void clear()
{
- BLINK_ASSERT_NOT_REACHED();
+ NOTREACHED();
}
// Merges all WebMemoryAllocatorDump(s) contained in |other| inside this
@@ -75,7 +75,7 @@ public:
// and can be reused as if it was new.
virtual void takeAllDumpsFrom(WebProcessMemoryDump* other)
{
- BLINK_ASSERT_NOT_REACHED();
+ NOTREACHED();
}
// Adds an ownership relationship between two MemoryAllocatorDump(s) with
@@ -86,12 +86,12 @@ public:
// memory.
virtual void addOwnershipEdge(WebMemoryAllocatorDumpGuid source, WebMemoryAllocatorDumpGuid target, int importance)
{
- BLINK_ASSERT_NOT_REACHED();
+ NOTREACHED();
}
virtual void addOwnershipEdge(WebMemoryAllocatorDumpGuid source, WebMemoryAllocatorDumpGuid target)
{
- BLINK_ASSERT_NOT_REACHED();
+ NOTREACHED();
}
// Utility method to add a suballocation relationship with the following
@@ -101,7 +101,7 @@ public:
// not account the memory of |source| in the target node.
virtual void addSuballocation(WebMemoryAllocatorDumpGuid source, const WebString& targetNodeName)
{
- BLINK_ASSERT_NOT_REACHED();
+ NOTREACHED();
}
// Returns the SkTraceMemoryDump proxy interface that can be passed to Skia
@@ -113,13 +113,13 @@ public:
// placed under different namespace and not "skia".
virtual SkTraceMemoryDump* createDumpAdapterForSkia(const WebString& dumpNamePrefix)
{
- BLINK_ASSERT_NOT_REACHED();
+ NOTREACHED();
return nullptr;
}
virtual blink::WebMemoryAllocatorDump* createDiscardableMemoryAllocatorDump(const std::string& name, base::DiscardableMemory* discardable)
{
- BLINK_ASSERT_NOT_REACHED();
+ NOTREACHED();
return nullptr;
}
@@ -127,7 +127,7 @@ public:
// base::trace_event::ProcessMemoryDump::AddHeapDump.
virtual void dumpHeapUsage(const base::hash_map<base::trace_event::AllocationContext, size_t>& bytesByContext, base::trace_event::TraceEventMemoryOverhead& overhead, const char* allocatorName)
{
- BLINK_ASSERT_NOT_REACHED();
+ NOTREACHED();
}
};

Powered by Google App Engine
This is Rietveld 408576698